From: Rob Herring <robh@kernel.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Mikhail Zhilkin" <csharper2005@gmail.com>,
"Christian Marangi" <ansuelsmth@gmail.com>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Chaitanya Kulkarni" <kch@nvidia.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"Jens Axboe" <axboe@kernel.dk>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 2/2] mtd: core: set ROOT_DEV for partitions marked as root devices in DT
Date: Thu, 20 Oct 2022 20:50:06 -0500 [thread overview]
Message-ID: <20221021015006.GA2145299-robh@kernel.org> (raw)
In-Reply-To: <c8d12dd0-7504-0198-dacb-b3723d82fc60@gmail.com>
On Wed, Oct 19, 2022 at 01:53:15PM +0200, Rafał Miłecki wrote:
> On 19.10.2022 13:50, Rafał Miłecki wrote:
> > From: Rafał Miłecki <rafal@milecki.pl>
> >
> > This adds support for "linux,root-device" binding that is used to mark
> > root device MTD partition. It's useful for devices using device tree
> > that don't have bootloader passing root info in cmdline.
> >
> > Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> > ---
> > drivers/mtd/mtdcore.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> > index 07249af4f890..034b06aff660 100644
> > --- a/drivers/mtd/mtdcore.c
> > +++ b/drivers/mtd/mtdcore.c
> > @@ -28,6 +28,7 @@
> > #include <linux/leds.h>
> > #include <linux/debugfs.h>
> > #include <linux/nvmem-provider.h>
> > +#include <linux/root_dev.h>
> > #include <linux/mtd/mtd.h>
> > #include <linux/mtd/partitions.h>
> > @@ -735,6 +736,12 @@ int add_mtd_device(struct mtd_info *mtd)
> > not->add(mtd);
> > mutex_unlock(&mtd_table_mutex);
> > +
> > + if (of_find_property(mtd_get_of_node(mtd), "linux,rootfs", NULL)) {
>
> I forgot to re-do "format-patch" after "commit --amend".
> s/linux,rootfs/linux,root-device/
It's really the filesystem you are tagging, not a device, so I think
'linux,rootfs' is better.
Rob
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2022-10-21 1:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 11:48 [PATCH 1/2] dt-bindings: mtd: partitions: support marking root device partition Rafał Miłecki
2022-10-19 11:50 ` [PATCH 2/2] mtd: core: set ROOT_DEV for partitions marked as root devices in DT Rafał Miłecki
2022-10-19 11:53 ` Rafał Miłecki
2022-10-21 1:50 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221021015006.GA2145299-robh@kernel.org \
--to=robh@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ansuelsmth@gmail.com \
--cc=axboe@kernel.dk \
--cc=csharper2005@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=kch@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=miquel.raynal@bootlin.com \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).