Hi Nathan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v6.1-rc7]
[also build test ERROR on linus/master next-20221202]
[cannot apply to mtd/spi-nor/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Nathan-Barrett-Morrison/mtd-spi-nor-Extend-SFDP-to-support-additional-octal-modes-as-per-latest-JEDEC-standard/20221202-215808
patch link:    https://lore.kernel.org/r/20221202135539.271936-4-nathan.morrison%40timesys.com
patch subject: [PATCH v4 3/3] mtd: spi-nor: Add support for IS25LX256 operating in 1S-8S-8S octal read mode
config: i386-randconfig-a001
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/26787a4933a6a8591b6a66fc036e3b3c674cb57c
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Nathan-Barrett-Morrison/mtd-spi-nor-Extend-SFDP-to-support-additional-octal-modes-as-per-latest-JEDEC-standard/20221202-215808
        git checkout 26787a4933a6a8591b6a66fc036e3b3c674cb57c
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/mtd/spi-nor/issi.c: In function 'is25lx256_post_bfpt_fixups':
>> drivers/mtd/spi-nor/issi.c:44:9: error: 'params' undeclared (first use in this function); did you mean 'parameq'?
      44 |         params->hwcaps.mask |= SNOR_HWCAPS_READ_1_1_8;
         |         ^~~~~~
         |         parameq
   drivers/mtd/spi-nor/issi.c:44:9: note: each undeclared identifier is reported only once for each function it appears in


vim +44 drivers/mtd/spi-nor/issi.c

    31	
    32	static int
    33	is25lx256_post_bfpt_fixups(struct spi_nor *nor,
    34				   const struct sfdp_parameter_header *bfpt_header,
    35				   const struct sfdp_bfpt *bfpt)
    36	{
    37		/*
    38		 * IS25LX256 supports both 1S-1S-8S and 1S-8S-8S.
    39		 * However, the BFPT does not contain any information denoting this
    40		 * functionality, so the proper fast read opcodes are never setup.
    41		 * We're correcting this issue via the fixup below.  Page program
    42		 * commands are detected and setup properly via the 4BAIT lookup.
    43		 */
  > 44		params->hwcaps.mask |= SNOR_HWCAPS_READ_1_1_8;
    45		spi_nor_set_read_settings(&params->reads[SNOR_CMD_READ_1_1_8],
    46					  0, 8, SPINOR_OP_READ_1_1_8,
    47					  SNOR_PROTO_1_1_8);
    48	
    49		params->hwcaps.mask |= SNOR_HWCAPS_READ_1_8_8;
    50		spi_nor_set_read_settings(&params->reads[SNOR_CMD_READ_1_8_8],
    51					  0, 16, SPINOR_OP_READ_1_8_8,
    52					  SNOR_PROTO_1_8_8);
    53	
    54		return 0;
    55	}
    56	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp