From: liaoweixiong <liaoweixiong@allwinnertech.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Schrempf Frieder <frieder.schrempf@kontron.de>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Boris Brezillon <bbrezillon@kernel.org>,
Richard Weinberger <richard@nod.at>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Greg KH <gregkh@linuxfoundation.org>,
Brian Norris <computersforpeace@gmail.com>,
Chuanhong Guo <gch981213@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips
Date: Fri, 28 Jun 2019 11:51:05 +0800 [thread overview]
Message-ID: <26a4597e-3881-73a2-07e3-6171ddd15d51@allwinnertech.com> (raw)
In-Reply-To: <20190627201742.34059cdf@xps13>
Hi Miquel,
On 2019/6/28 AM2:17, Miquel Raynal wrote:
> Hi Miquel,
>
> Miquel Raynal <miquel.raynal@bootlin.com> wrote on Thu, 27 Jun 2019
> 19:06:44 +0200:
>
>> Hello,
>>
>> Schrempf Frieder <frieder.schrempf@kontron.de> wrote on Tue, 25 Jun
>> 2019 07:04:06 +0000:
>>
>>> Hi liaoweixiong,
>>>
>>> On 25.06.19 05:08, Greg KH wrote:
>>>> On Tue, Jun 25, 2019 at 09:02:29AM +0800, liaoweixiong wrote:
>>>>> In case of the last page containing bitflips (ret > 0),
>>>>> spinand_mtd_read() will return that number of bitflips for the last
>>>>> page. But to me it looks like it should instead return max_bitflips like
>>>>> it does when the last page read returns with 0.
>>>>>
>>>>> Signed-off-by: liaoweixiong <liaoweixiong@allwinnertech.com>
>>
>> Please write your entire official first/last name(s)
>>
OK.
>>>>> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
>>>>> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> I am waiting your next version with Acked-by instead of Rewieved-by
>> tags and Greg's comment addressed.
>
> Sorry for the mistake, R-b tags are fine here, don't touch that.
> The rest needs to be fixed though.
>
OK.
>>>>> Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs")
>>
>> Finally, when we ask you to resend a patch, it means sending a new
>> version of the patch. So in the subject, you should not use the
>> [RESEND] keyword (which means you are sending something again exactly
>> as it was before, you just got ignored, for example) but instead you
>> should increment the version number (v3) and also write a nice
>> changelog after the three dashes '---' (will be ignored by Git when
>> applying).
>>
>> I would like to queue this for the next release so if you can do it
>> ASAP, that would be great.
>>
I will do it right now.
>> Thank you,
>> Miquèl
>
>
>
>
> Thanks,
> Miquèl
>
--
liaoweixiong
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-06-28 3:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 1:02 [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips liaoweixiong
2019-06-25 3:08 ` Greg KH
2019-06-25 7:04 ` Schrempf Frieder
2019-06-25 11:56 ` liaoweixiong
2019-06-25 12:04 ` Schrempf Frieder
2019-06-27 17:06 ` Miquel Raynal
2019-06-27 18:17 ` Miquel Raynal
2019-06-28 3:51 ` liaoweixiong [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-06-25 12:03 liaoweixiong
2019-06-24 12:15 liaoweixiong
2019-06-24 14:47 ` Schrempf Frieder
2019-06-25 1:00 ` liaoweixiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26a4597e-3881-73a2-07e3-6171ddd15d51@allwinnertech.com \
--to=liaoweixiong@allwinnertech.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=frieder.schrempf@kontron.de \
--cc=gch981213@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).