From: Johan Jonker <jbx6244@gmail.com>
To: Jon Lin <jon.lin@rock-chips.com>, linux-spi@vger.kernel.org
Cc: broonie@kernel.org, robh+dt@kernel.org, heiko@sntech.de,
hjc@rock-chips.com, yifeng.zhao@rock-chips.com,
sugar.zhang@rock-chips.com, linux-rockchip@lists.infradead.org,
linux-mtd@lists.infradead.org, p.yadav@ti.com,
macroalpha82@gmail.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH v6 4/8] clk: rockchip: Add support for hclk_sfc on rk3036
Date: Tue, 8 Jun 2021 18:31:33 +0200 [thread overview]
Message-ID: <4a4524f5-ee85-c7f6-aa95-1df84f2a8a99@gmail.com> (raw)
In-Reply-To: <20210608022644.21074-5-jon.lin@rock-chips.com>
Hi Jon,
For rk3036 we might need another fix added to this serie as well.
clk: rockchip: rk3036: fix up the sclk_sfc parent error
https://github.com/rockchip-linux/kernel/commit/100718ef0d44872db1672b6a88030374c0d1613b
===
Add more people for clk driver changes:
M: Michael Turquette <mturquette@baylibre.com>
M: Stephen Boyd <sboyd@kernel.org>
L: linux-clk@vger.kernel.org
===
Johan
On 6/8/21 4:26 AM, Jon Lin wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
From: Randy Li <randy.li@rock-chips.com>
>
> Add support for the bus clock for the serial flash controller on the
> rk3036. Taken from the Rockchip BSP kernel but not tested on real
> hardware (as I lack a 3036 based SoC to test).
>
Signed-off-by: Randy Li <randy.li@rock-chips.com>
Maybe give credit to the original author?
clk: rockchip: rk3036: export the sfc clocks
https://github.com/rockchip-linux/kernel/commit/600925e8ef6edbdda0a4ac6b3c55b0199be1e03e
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
> ---
>
> Changes in v6: None
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> Changes in v1: None
>
> drivers/clk/rockchip/clk-rk3036.c | 2 +-
> include/dt-bindings/clock/rk3036-cru.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/rockchip/clk-rk3036.c b/drivers/clk/rockchip/clk-rk3036.c
> index 91d56ad45817..ebb628733f6d 100644
> --- a/drivers/clk/rockchip/clk-rk3036.c
> +++ b/drivers/clk/rockchip/clk-rk3036.c
> @@ -403,7 +403,7 @@ static struct rockchip_clk_branch rk3036_clk_branches[] __initdata = {
> GATE(HCLK_OTG0, "hclk_otg0", "hclk_peri", CLK_IGNORE_UNUSED, RK2928_CLKGATE_CON(5), 13, GFLAGS),
> GATE(HCLK_OTG1, "hclk_otg1", "hclk_peri", CLK_IGNORE_UNUSED, RK2928_CLKGATE_CON(7), 3, GFLAGS),
> GATE(HCLK_I2S, "hclk_i2s", "hclk_peri", 0, RK2928_CLKGATE_CON(7), 2, GFLAGS),
> - GATE(0, "hclk_sfc", "hclk_peri", CLK_IGNORE_UNUSED, RK2928_CLKGATE_CON(3), 14, GFLAGS),
> + GATE(HCLK_SFC, "hclk_sfc", "hclk_peri", CLK_IGNORE_UNUSED, RK2928_CLKGATE_CON(3), 14, GFLAGS),
Maybe CLK_IGNORE_UNUSED should be changed to 0 ?
> GATE(HCLK_MAC, "hclk_mac", "hclk_peri", 0, RK2928_CLKGATE_CON(3), 5, GFLAGS),
>
> /* pclk_peri gates */
> diff --git a/include/dt-bindings/clock/rk3036-cru.h b/include/dt-bindings/clock/rk3036-cru.h
> index 35a5a01f9697..a96a9870ad59 100644
> --- a/include/dt-bindings/clock/rk3036-cru.h
> +++ b/include/dt-bindings/clock/rk3036-cru.h
> @@ -81,6 +81,7 @@
> #define HCLK_OTG0 449
> #define HCLK_OTG1 450
> #define HCLK_NANDC 453
> +#define HCLK_SFC 454
> #define HCLK_SDMMC 456
> #define HCLK_SDIO 457
> #define HCLK_EMMC 459
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-06-08 16:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 2:26 [PATCH v6 0/8] Add Rockchip SFC(serial flash controller) support Jon Lin
2021-06-08 2:26 ` [PATCH v6 1/8] dt-bindings: rockchip-sfc: Bindings for Rockchip serial flash controller Jon Lin
2021-06-08 18:03 ` Johan Jonker
2021-06-09 3:50 ` Jon Lin
2021-06-09 7:13 ` Johan Jonker
2021-06-08 20:50 ` Rob Herring
2021-06-08 2:26 ` [PATCH v6 2/8] spi: rockchip-sfc: add rockchip " Jon Lin
2021-06-09 2:36 ` Chris Morgan
2021-06-09 13:48 ` Jon Lin
2021-06-09 16:57 ` Chris Morgan
2021-06-08 2:26 ` [PATCH v6 3/8] arm64: dts: rockchip: Add SFC to PX30 Jon Lin
2021-06-08 2:26 ` [PATCH v6 4/8] clk: rockchip: Add support for hclk_sfc on rk3036 Jon Lin
2021-06-08 16:31 ` Johan Jonker [this message]
2021-06-09 14:18 ` Jon Lin
2021-06-09 14:23 ` Jon Lin
2021-06-08 2:33 ` [PATCH v6 5/8] arm: dts: rockchip: Add SFC to RK3036 Jon Lin
2021-06-08 2:33 ` [PATCH v6 6/8] arm: dts: rockchip: Add SFC to RV1108 Jon Lin
2021-06-08 2:33 ` [PATCH v6 7/8] arm64: dts: rockchip: Add SFC to RK3308 Jon Lin
2021-06-08 2:33 ` [PATCH v6 8/8] arm64: dts: rockchip: Enable SFC for Odroid Go Advance Jon Lin
2021-06-08 18:39 ` [PATCH v6 5/8] arm: dts: rockchip: Add SFC to RK3036 Johan Jonker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a4524f5-ee85-c7f6-aa95-1df84f2a8a99@gmail.com \
--to=jbx6244@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jon.lin@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=p.yadav@ti.com \
--cc=robh+dt@kernel.org \
--cc=sugar.zhang@rock-chips.com \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).