From: Neil Armstrong <narmstrong@baylibre.com>
To: Pavel Machek <pavel@ucw.cz>,
trivial@kernel.org, miquel.raynal@bootlin.com, richard@nod.at,
vigneshr@ti.com, nishkadg.linux@gmail.com,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-oxnas@groups.io,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: rawnand: oxnas: cleanup/simplify code
Date: Fri, 24 Jul 2020 12:01:53 +0200 [thread overview]
Message-ID: <7037f4aa-6b6d-9354-ab4a-261dd754312e@baylibre.com> (raw)
In-Reply-To: <20200724083825.GA31437@amd>
[-- Attachment #1.1.1: Type: text/plain, Size: 694 bytes --]
On 24/07/2020 10:38, Pavel Machek wrote:
> Simplify oxnas_nand_probe.
>
> Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
>
> diff --git a/drivers/mtd/nand/raw/oxnas_nand.c b/drivers/mtd/nand/raw/oxnas_nand.c
> index 8d0d76ad319d..f44947043e5a 100644
> --- a/drivers/mtd/nand/raw/oxnas_nand.c
> +++ b/drivers/mtd/nand/raw/oxnas_nand.c
> @@ -144,8 +144,7 @@ static int oxnas_nand_probe(struct platform_device *pdev)
> if (err)
> goto err_cleanup_nand;
>
> - oxnas->chips[oxnas->nchips] = chip;
> - ++oxnas->nchips;
> + oxnas->chips[oxnas->nchips++] = chip;
> }
>
> /* Exit if no chips found */
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-07-24 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 8:38 [PATCH] mtd: rawnand: oxnas: cleanup/simplify code Pavel Machek
2020-07-24 10:01 ` Neil Armstrong [this message]
2020-09-07 7:22 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7037f4aa-6b6d-9354-ab4a-261dd754312e@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-oxnas@groups.io \
--cc=miquel.raynal@bootlin.com \
--cc=nishkadg.linux@gmail.com \
--cc=pavel@ucw.cz \
--cc=richard@nod.at \
--cc=trivial@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).