linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: <Tudor.Ambarus@microchip.com>
To: <ahmet.celenk@procenne.com>, <linux-mtd@lists.infradead.org>
Cc: marek.vasut@gmail.com, bbrezillon@kernel.org
Subject: Re: [PATCH V3] mtd: spi-nor: split s25fl128s into s25fl128s0 and s25fl128s1
Date: Thu, 7 Feb 2019 08:16:55 +0000	[thread overview]
Message-ID: <7b33d1ab-835b-781a-b2e9-f271dc493afa@microchip.com> (raw)
In-Reply-To: <1549518234-15211-1-git-send-email-ahmet.celenk@procenne.com>

Hi, Ahmet,

On 02/07/2019 07:43 AM, A. Celenk wrote:
> From: "Ahmet Celenk" <ahmet.celenk@procenne.com>
> 
> Due to two different versions (S25FL128SAGBHI200 and S25FL128SAGBHI210) of
> the s25fl128s qspi memory, the single "s25fl128s" device entry must be
> split into two to match the correct JEDEC ID's for each version. Solves
> paging related issues of S25FL128SAGBHI210 chips.
> 
> Signed-off-by: Ahmet Celenk <ahmet.celenk@procenne.com>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> ---
> V3: Added missing SPI_NOR_DUAL_READ flags to new entries
> V2: Removed the old s25fl128s entry
> 
>  drivers/mtd/spi-nor/spi-nor.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 6e13bbd..3cd9052 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1891,7 +1891,8 @@ static const struct flash_info spi_nor_ids[] = {
>  	{ "s70fl01gs",  INFO(0x010221, 0x4d00, 256 * 1024, 256, 0) },
>  	{ "s25sl12800", INFO(0x012018, 0x0300, 256 * 1024,  64, 0) },
>  	{ "s25sl12801", INFO(0x012018, 0x0301,  64 * 1024, 256, 0) },
> -	{ "s25fl128s",  INFO6(0x012018, 0x4d0180, 64 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
> +	{ "s25fl128s0", INFO6(0x012018, 0x4d0080, 256 * 1024, 64, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
> +	{ "s25fl128s1", INFO6(0x012018, 0x4d0180, 64 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },

The patch is good, there are few nitpicks however. Would you please fix them?

When running checkpatch I get:
$ ./scripts/checkpatch.pl --strict
V3-mtd-spi-nor-split-s25fl128s-into-s25fl128s0-and-s25fl128s1.patch
WARNING: line over 80 characters
#43: FILE: drivers/mtd/spi-nor/spi-nor.c:1894:
+	{ "s25fl128s0", INFO6(0x012018, 0x4d0080, 256 * 1024, 64, SPI_NOR_DUAL_READ |
SPI_NOR_QUAD_READ | USE_CLSR) },

WARNING: line over 80 characters
#44: FILE: drivers/mtd/spi-nor/spi-nor.c:1895:
+	{ "s25fl128s1", INFO6(0x012018, 0x4d0180, 64 * 1024, 256, SPI_NOR_DUAL_READ |
SPI_NOR_QUAD_READ | USE_CLSR) },

Please choose the following format, it has fewer lines:
        { "s25fl128s0", INFO6(0x012018, 0x4d0080, 256 * 1024, 64,
                        SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
        { "s25fl128s1", INFO6(0x012018, 0x4d0180, 64 * 1024, 256,
                        SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },

While here, would you please place these 2 entries in alphabetical order? They
belong just before "s25fl256s0" entry.

Thanks!
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2019-02-07  8:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-07  5:43 [PATCH V3] mtd: spi-nor: split s25fl128s into s25fl128s0 and s25fl128s1 A. Celenk
2019-02-07  8:16 ` Tudor.Ambarus [this message]
2019-02-08  5:27   ` A. Celenk
2019-02-08  9:20     ` Tudor.Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b33d1ab-835b-781a-b2e9-f271dc493afa@microchip.com \
    --to=tudor.ambarus@microchip.com \
    --cc=ahmet.celenk@procenne.com \
    --cc=bbrezillon@kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).