linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Christophe Kerello <christophe.kerello@st.com>
To: Marek Vasut <marex@denx.de>, <miquel.raynal@bootlin.com>,
	<richard@nod.at>, <vigneshr@ti.com>, <lee.jones@linaro.org>,
	<robh+dt@kernel.org>, <mark.rutland@arm.com>, <tony@atomide.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [03/12] bus: stm32-fmc2-ebi: add STM32 FMC2 EBI controller driver
Date: Mon, 30 Mar 2020 11:19:55 +0200	[thread overview]
Message-ID: <93fce520-9269-123c-9523-173e75cdce2e@st.com> (raw)
In-Reply-To: <f6a2c766-8ae5-fab7-e2f6-db23f39b5d91@denx.de>



On 3/30/20 3:24 AM, Marek Vasut wrote:
> On 3/23/20 3:58 PM, Christophe Kerello wrote:
>> The driver adds the support for the STMicroelectronics FMC2 EBI controller
>> found on STM32MP SOCs.
>>
> 
> On DH STM32MP1 SoM in PDK2 carrier board,
> Tested-by: Marek Vasut <marex@denx.de>
> 
> btw. it seems this sets BTRx DATLAT and CLKDIV to 0xf , it's "Don't
> care" in the datasheet for Muxed mode, but then it should probably be
> set to 0.

Hi Marek,

Thanks for testing.

These 2 bit fields (BTRx DATLAT and CLKDIV) are only needed for 
synchronous transactions. Based on your bindings, the transaction type 
is asynchronous.
CLKDIV bit fields should not be set to 0x0, as this value is reserved 
for this bit field. The driver keeps the reset value when it is not 
needed to update a bit field.

Regards,
Christophe Kerello.

> 
> The bindings I used are below:
> 
> &fmc {
>          pinctrl-names = "default", "sleep";
>          pinctrl-0 = <&fmc_pins_b>;
>          pinctrl-1 = <&fmc_sleep_pins_b>;
>          status = "okay";
>          #address-cells = <1>;
>          #size-cells = <1>;
>          /delete-property/interrupts;
>          /delete-property/dmas;
>          /delete-property/dma-names;
>          reg = <0x58002000 0x1000>;
>          ranges;
> 
>          ebi {
>                  #address-cells = <2>;
>                  #size-cells = <1>;
>                  compatible = "st,stm32mp1-fmc2-ebi";
>                  ranges = <0 0 0x60000000 0x4000000>,
>                           <1 0 0x64000000 0x4000000>,
>                           <2 0 0x68000000 0x4000000>,
>                           <3 0 0x6c000000 0x4000000>;
> 
>                  ksz8851: ks8851mll@0,0 {
>                          compatible = "micrel,ks8851-mll";
>                          reg = <1 0x0 0x2 1 0x2 0x20000>;
>                          interrupt-parent = <&gpioc>;
>                          interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
>                          bank-width = <2>;
> 
>                          /* Timing values are in nS */
>                          st,fmc2_ebi_cs_mux_enable;
>                          st,fmc2_ebi_cs_transaction_type = <4>;
>                          st,fmc2_ebi_cs_buswidth = <16>;
>                          st,fmc2_ebi_cs_address_setup = <6>;
>                          st,fmc2_ebi_cs_address_hold = <6>;
>                          st,fmc2_ebi_cs_data_setup = <127>;
>                          st,fmc2_ebi_cs_bus_turnaround = <9>;
>                          st,fmc2_ebi_cs_data_hold = <9>;
>                  };
> 
>                  sram@3,0 {
>                          compatible = "mtd-ram";
>                          reg = <3 0x0 0x80000>;
>                          bank-width = <2>;
> 
>                          /* Timing values are in nS */
>                          st,fmc2_ebi_cs_mux_enable;
>                          st,fmc2_ebi_cs_transaction_type = <4>;
>                          st,fmc2_ebi_cs_buswidth = <16>;
>                          st,fmc2_ebi_cs_address_setup = <6>;
>                          st,fmc2_ebi_cs_address_hold = <6>;
>                          st,fmc2_ebi_cs_data_setup = <127>;
>                          st,fmc2_ebi_cs_bus_turnaround = <9>;
>                          st,fmc2_ebi_cs_data_hold = <9>;
>                  };
>          };
> };
> 

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2020-03-30  9:20 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23 14:58 [00/12] add STM32 FMC2 controller drivers Christophe Kerello
2020-03-23 14:58 ` [01/12] dt-bindings: mfd: stm32-fmc2: add STM32 FMC2 controller documentation Christophe Kerello
2020-03-23 14:58 ` [02/12] mfd: stm32-fmc2: add STM32 FMC2 controller driver Christophe Kerello
2020-03-29 23:36   ` Marek Vasut
2020-03-30  9:18     ` Christophe Kerello
2020-03-23 14:58 ` [03/12] bus: stm32-fmc2-ebi: add STM32 FMC2 EBI " Christophe Kerello
2020-03-30  1:24   ` Marek Vasut
2020-03-30  9:19     ` Christophe Kerello [this message]
2020-03-30  9:30       ` Marek Vasut
2020-03-23 14:58 ` [04/12] mtd: rawnand: stm32_fmc2: manage all errors cases at probe time Christophe Kerello
2020-03-23 14:58 ` [05/12] mtd: rawnand: stm32_fmc2: remove useless inline comments Christophe Kerello
2020-03-23 14:58 ` [06/12] mtd: rawnand: stm32_fmc2: use FMC2_TIMEOUT_MS for timeouts Christophe Kerello
2020-03-23 14:58 ` [07/12] mtd: rawnand: stm32_fmc2: cleanup Christophe Kerello
2020-03-23 14:58 ` [08/12] mtd: rawnand: stm32_fmc2: use FIELD_PREP/FIELD_GET macros Christophe Kerello
2020-03-23 14:58 ` [09/12] mtd: rawnand: stm32_fmc2: move all registers Christophe Kerello
2020-03-23 14:58 ` [10/12] mtd: rawnand: stm32_fmc2: use regmap APIs Christophe Kerello
2020-03-24  0:44   ` Marek Vasut
2020-03-24 10:38     ` Christophe Kerello
2020-03-23 14:58 ` [11/12] mtd: rawnand: stm32_fmc2: use stm32_fmc2 structure in nfc controller Christophe Kerello
2020-03-23 14:58 ` [12/12] mtd: rawnand: stm32_fmc2: add new MP1 compatible string Christophe Kerello
2020-03-24  0:37 ` [00/12] add STM32 FMC2 controller drivers Marek Vasut
2020-03-24  7:36   ` Christophe Kerello
2020-03-24 13:27     ` Marek Vasut
2020-03-24 13:37       ` Christophe Kerello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93fce520-9269-123c-9523-173e75cdce2e@st.com \
    --to=christophe.kerello@st.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=marex@denx.de \
    --cc=mark.rutland@arm.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).