From: Richard Weinberger <richard.weinberger@gmail.com>
To: Zhe Li <lizhe67@huawei.com>
Cc: qiuxi1@huawei.com, Richard Weinberger <richard@nod.at>,
LKML <linux-kernel@vger.kernel.org>,
linux-mtd@lists.infradead.org, wangfangpeng1@huawei.com,
zhongjubin@huawei.com, David Woodhouse <dwmw2@infradead.org>,
chenjie6@huawei.com
Subject: Re: [PATCH 1/2] jffs2: fix ignoring mounting options problem during remounting
Date: Tue, 10 Nov 2020 22:34:17 +0100 [thread overview]
Message-ID: <CAFLxGvwO_i31AF350i+9w-7wg25NToyVFFBcG2oHXW3m9sS+MQ@mail.gmail.com> (raw)
In-Reply-To: <20201014065443.18512-1-lizhe67@huawei.com>
On Wed, Oct 14, 2020 at 9:01 AM Zhe Li <lizhe67@huawei.com> wrote:
>
> From: lizhe <lizhe67@huawei.com>
>
> The jffs2 mount options will be ignored when remounting jffs2.
> It can be easily reproduced with the steps listed below.
> 1. mount -t jffs2 -o compr=none /dev/mtdblockx /mnt
> 2. mount -o remount compr=zlib /mnt
>
> Since ec10a24f10c8, the option parsing happens before fill_super and
> then pass fc, which contains the options parsing results, to function
> jffs2_reconfigure during remounting. But function jffs2_reconfigure do
> not update c->mount_opts.
>
> This patch add a function jffs2_update_mount_opts to fix this problem.
Oh, a regression. Thanks for fixing.
> By the way, I notice that tmpfs use the same way to update remounting
> options. If it is necessary to unify them?
If possible, sure. Maybe you can find a way to put the logic into fs/libfs.c
--
Thanks,
//richard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2020-11-10 21:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 6:54 [PATCH 1/2] jffs2: fix ignoring mounting options problem during remounting Zhe Li
2020-10-14 6:54 ` [PATCH 2/2] jffs2: fix can't set rp_size to zero " Zhe Li
2020-11-19 2:50 ` Zhe Li
2020-11-23 8:18 ` Richard Weinberger
2020-11-06 2:30 ` [PATCH 1/2] jffs2: fix ignoring mounting options problem " Zhe Li
2020-11-10 21:34 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFLxGvwO_i31AF350i+9w-7wg25NToyVFFBcG2oHXW3m9sS+MQ@mail.gmail.com \
--to=richard.weinberger@gmail.com \
--cc=chenjie6@huawei.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=lizhe67@huawei.com \
--cc=qiuxi1@huawei.com \
--cc=richard@nod.at \
--cc=wangfangpeng1@huawei.com \
--cc=zhongjubin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).