From: "Matthias Weißer" <m.weisser.m@gmail.com>
To: Yicong Yang <yangyicong@hisilicon.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
sergei.shtylyov@cogentembedded.com, tudor.ambarus@microchip.com,
richard@nod.at, me@yadavpratyush.com, john.garry@huawei.com,
linuxarm@huawei.com, linux-mtd@lists.infradead.org,
miquel.raynal@bootlin.com, alexander.sverdlin@nokia.com,
Pratyush Yadav <p.yadav@ti.com>
Subject: Re: [PATCH 2/2] mtd: spi-nor: Disable the flash quad mode in spi_nor_restore()
Date: Fri, 4 Sep 2020 11:35:43 +0200 [thread overview]
Message-ID: <CAO8h3eFWHH0sq-37Etdu99+ULYFrkFLuh5SP1qDPFseStBchqQ@mail.gmail.com> (raw)
In-Reply-To: <0c3dcb65-3a6d-d742-da83-3b71f5417115@hisilicon.com>
Am Fr., 4. Sept. 2020 um 09:55 Uhr schrieb Yicong Yang
<yangyicong@hisilicon.com>:
> > Given the fact that setting and unsetting NV bit causes wearing of this
> > rather important bit and also breaks backward compatibility of tools
> > that expect Kernel to set QE bit on flashing, I suggest reverting these patches:
> >
> > cc59e6bb6cd6 mtd: spi-nor: Disable the flash quad mode in spi_nor_restore()
> > be192209d5a3 mtd: spi-nor: Add capability to disable flash quad mode
>
> I've send the revert patches. You may found at :
> https://lore.kernel.org/linux-mtd/1599205640-26690-1-git-send-email-yangyicong@hisilicon.com/
Thanks. I think this is currently the way to go.
> but I still have something uncertain, I think we should avoid setting the non-volatile bits
> in spi-nor driver, should we?
Why not? If quad mode should be used the QE bit has to be set. There is no
other way to enable quad mode (on the devices I am aware of).
Regards,
Matthias
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-09-04 9:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 13:02 [PATCH 0/2] Add support to Disable the flash quad mode Yicong Yang
2020-06-16 13:02 ` [PATCH 1/2] mtd: spi-nor: Add capability to disable " Yicong Yang
2020-07-02 11:07 ` Tudor.Ambarus
2020-06-16 13:02 ` [PATCH 2/2] mtd: spi-nor: Disable the flash quad mode in spi_nor_restore() Yicong Yang
2020-07-02 11:02 ` Tudor.Ambarus
2020-07-03 11:19 ` Pratyush Yadav
2020-07-03 11:52 ` Tudor.Ambarus
2020-07-06 6:47 ` Yicong Yang
2020-09-01 6:16 ` Matthias Weißer
2020-09-01 9:48 ` Pratyush Yadav
2020-09-01 10:08 ` Matthias Weißer
2020-09-01 11:11 ` Pratyush Yadav
2020-09-01 11:41 ` Yicong Yang
2020-09-01 14:20 ` Yicong Yang
2020-09-02 7:50 ` Vignesh Raghavendra
2020-09-02 10:12 ` Yicong Yang
2020-09-03 5:59 ` Vignesh Raghavendra
2020-09-04 7:54 ` Yicong Yang
2020-09-04 9:35 ` Matthias Weißer [this message]
2020-09-02 12:15 ` Matthias Weißer
2020-09-03 3:03 ` Yicong Yang
2020-09-03 5:33 ` Matthias Weißer
2020-09-04 7:56 ` Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO8h3eFWHH0sq-37Etdu99+ULYFrkFLuh5SP1qDPFseStBchqQ@mail.gmail.com \
--to=m.weisser.m@gmail.com \
--cc=alexander.sverdlin@nokia.com \
--cc=john.garry@huawei.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxarm@huawei.com \
--cc=me@yadavpratyush.com \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).