From: "Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@micron.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Boris Brezillon <bbrezillon@kernel.org>,
"shiva.linuxworks@gmail.com" <shiva.linuxworks@gmail.com>,
Richard Weinberger <richard@nod.at>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: RE: [EXT] Re: [PATCH v4 2/5] mtd: spinand: micron: Add new Micron SPI NAND devices
Date: Thu, 27 Feb 2020 20:16:46 +0000 [thread overview]
Message-ID: <MN2PR08MB6397477172BAC14986175E6DB8EB0@MN2PR08MB6397.namprd08.prod.outlook.com> (raw)
In-Reply-To: <20200227192247.52f84723@collabora.com>
Hi Boris,
Thanks for the review.
>
> On Thu, 6 Feb 2020 21:22:03 +0100
> shiva.linuxworks@gmail.com wrote:
>
> > From: Shivamurthy Shastri <sshivamurthy@micron.com>
> >
> > Add device table for M79A and M78A series Micron SPI NAND devices.
> >
> > Signed-off-by: Shivamurthy Shastri <sshivamurthy@micron.com>
> > ---
> > drivers/mtd/nand/spi/micron.c | 31
> +++++++++++++++++++++++++++++++
> > 1 file changed, 31 insertions(+)
> >
> > diff --git a/drivers/mtd/nand/spi/micron.c
> b/drivers/mtd/nand/spi/micron.c
> > index c028d0d7e236..5fd1f921ef12 100644
> > --- a/drivers/mtd/nand/spi/micron.c
> > +++ b/drivers/mtd/nand/spi/micron.c
> > @@ -91,6 +91,7 @@ static int micron_8_ecc_get_status(struct
> spinand_device *spinand,
> > }
> >
> > static const struct spinand_info micron_spinand_table[] = {
> > + /* M79A 2Gb 3.3V */
>
> Should be added in a separate patch.
Okay, I will create separate patch for each device.
>
> > SPINAND_INFO("MT29F2G01ABAGD", 0x24,
> > NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 2, 1, 1),
> > NAND_ECCREQ(8, 512),
> > @@ -100,6 +101,36 @@ static const struct spinand_info
> micron_spinand_table[] = {
> > 0,
> > SPINAND_ECCINFO(µn_8_ooblayout,
> > micron_8_ecc_get_status)),
> > + /* M79A 2Gb 1.8V */
> > + SPINAND_INFO("MT29F2G01ABBGD", 0x25,
> > + NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 2, 1, 1),
> > + NAND_ECCREQ(8, 512),
> > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
> > + &write_cache_variants,
> > + &update_cache_variants),
> > + 0,
> > + SPINAND_ECCINFO(µn_8_ooblayout,
> > + micron_8_ecc_get_status)),
> > + /* M78A 1Gb 3.3V */
> > + SPINAND_INFO("MT29F1G01ABAFD", 0x14,
> > + NAND_MEMORG(1, 2048, 128, 64, 1024, 20, 1, 1, 1),
> > + NAND_ECCREQ(8, 512),
> > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
> > + &write_cache_variants,
> > + &update_cache_variants),
> > + 0,
> > + SPINAND_ECCINFO(µn_8_ooblayout,
> > + micron_8_ecc_get_status)),
> > + /* M78A 1Gb 1.8V */
> > + SPINAND_INFO("MT29F1G01ABAFD", 0x15,
> > + NAND_MEMORG(1, 2048, 128, 64, 1024, 20, 1, 1, 1),
> > + NAND_ECCREQ(8, 512),
> > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
> > + &write_cache_variants,
> > + &update_cache_variants),
> > + 0,
> > + SPINAND_ECCINFO(µn_8_ooblayout,
> > + micron_8_ecc_get_status)),
> > };
> >
> > static int micron_spinand_detect(struct spinand_device *spinand)
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-02-27 20:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 20:22 [PATCH v4 0/5] Add new series Micron SPI NAND devices shiva.linuxworks
2020-02-06 20:22 ` [PATCH v4 1/5] mtd: spinand: micron: Generalize the OOB layout structure and function names shiva.linuxworks
2020-02-27 18:22 ` Boris Brezillon
2020-02-06 20:22 ` [PATCH v4 2/5] mtd: spinand: micron: Add new Micron SPI NAND devices shiva.linuxworks
2020-02-27 18:22 ` Boris Brezillon
2020-02-27 20:16 ` Shivamurthy Shastri (sshivamurthy) [this message]
2020-02-27 20:17 ` [EXT] " Boris Brezillon
2020-02-27 20:24 ` Shivamurthy Shastri (sshivamurthy)
2020-02-27 20:52 ` Boris Brezillon
2020-02-06 20:22 ` [PATCH v4 3/5] mtd: spinand: micron: identify SPI NAND device with Continuous Read mode shiva.linuxworks
2020-02-27 18:07 ` Boris Brezillon
2020-02-27 20:34 ` [EXT] " Shivamurthy Shastri (sshivamurthy)
2020-02-06 20:22 ` [PATCH v4 4/5] mtd: spinand: micron: Add M70A series Micron SPI NAND devices shiva.linuxworks
2020-02-27 18:23 ` Boris Brezillon
2020-02-06 20:22 ` [PATCH v4 5/5] mtd: spinand: micron: Add new Micron SPI NAND devices with multiple dies shiva.linuxworks
2020-02-27 18:15 ` Boris Brezillon
2020-02-26 17:05 ` [EXT] [PATCH v4 0/5] Add new series Micron SPI NAND devices Shivamurthy Shastri (sshivamurthy)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR08MB6397477172BAC14986175E6DB8EB0@MN2PR08MB6397.namprd08.prod.outlook.com \
--to=sshivamurthy@micron.com \
--cc=bbrezillon@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=frieder.schrempf@kontron.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=shiva.linuxworks@gmail.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).