From: masonccyang@mxic.com.tw
To: "Miquel Raynal" <miquel.raynal@bootlin.com>
Cc: vigneshr@ti.com, bbrezillon@kernel.org, juliensu@mxic.com.tw,
richard@nod.at, linux-kernel@vger.kernel.org,
marek.vasut@gmail.com, linux-mtd@lists.infradead.org,
computersforpeace@gmail.com, dwmw2@infradead.org
Subject: Re: [PATCH v2 2/4] mtd: rawnand: Add support Macronix Block Protection function
Date: Mon, 17 Feb 2020 16:24:34 +0800 [thread overview]
Message-ID: <OF29F7BCDB.FE14909F-ON48258511.002D91A4-48258511.002E31F0@mxic.com.tw> (raw)
In-Reply-To: <20200109174713.71ea377b@xps13>
Hi Miquel,
> > +/*
> > + * Macronix NAND supports Block Protection by Protectoin(PT) pin;
> > + * active high at power-on which protects the entire chip even the
#WP is
> > + * disabled. Lock/unlock protection area can be partition according
to
> > + * protection bits, i.e. upper 1/2 locked, upper 1/4 locked and so
on.
> > + */
> > +static int mxic_nand_lock(struct nand_chip *chip, loff_t ofs,
uint64_t len)
> > +{
> > + u8 feature[ONFI_SUBFEATURE_PARAM_LEN];
> > + int ret;
> > +
> > + feature[0] = MXIC_BLOCK_PROTECTION_ALL_LOCK;
> > + nand_select_target(chip, 0);
> > + ret = nand_set_features(chip, ONFI_FEATURE_ADDR_MXIC_PROTECTION,
> > + feature);
> > + nand_deselect_target(chip);
> > + if (ret)
> > + pr_err("%s all blocks failed\n", __func__);
> > +
> > + return ret;
> > +}
> > +
> > +static int mxic_nand_unlock(struct nand_chip *chip, loff_t ofs,
uint64_t len)
> > +{
> > + u8 feature[ONFI_SUBFEATURE_PARAM_LEN];
> > + int ret;
> > +
> > + feature[0] = MXIC_BLOCK_PROTECTION_ALL_UNLOCK;
> > + nand_select_target(chip, 0);
> > + ret = nand_set_features(chip, ONFI_FEATURE_ADDR_MXIC_PROTECTION,
> > + feature);
> > + nand_deselect_target(chip);
> > + if (ret)
> > + pr_err("%s all blocks failed\n", __func__);
> > +
> > + return ret;
> > }
> >
> > +/*
> > + * Macronix NAND AC series support Block Protection by SET_FEATURES
> > + * to lock/unlock blocks.
> > + */
> > static int macronix_nand_init(struct nand_chip *chip)
> > {
> > + bool blockprotected = false;
> > +
> > if (nand_is_slc(chip))
> > chip->options |= NAND_BBM_FIRSTPAGE | NAND_BBM_SECONDPAGE;
> >
> > - macronix_nand_fix_broken_get_timings(chip);
> > + if (macronix_nand_fix_broken_get_timings(chip))
> > + blockprotected = true;
>
> I don't like this at all :)
>
> Please create a helper which detects which part is broken/protected
> then create helpers to act in this case.
okay, will patch it to read default protected value (after power-on)
for protection function detection.
>
> If the list is absolutely identical, you can share the detection
> helper. Otherwise, if you think the list can diverge, please only share
> the list for now and create two detection helpers.
>
> > +
> > macronix_nand_onfi_init(chip);
> >
> > + if (blockprotected) {
> > + bitmap_set(chip->parameters.set_feature_list,
> > + ONFI_FEATURE_ADDR_MXIC_PROTECTION, 1);
> > + bitmap_set(chip->parameters.get_feature_list,
> > + ONFI_FEATURE_ADDR_MXIC_PROTECTION, 1);
> > +
> > + chip->_lock = mxic_nand_lock;
> > + chip->_unlock = mxic_nand_unlock;
> > + }
> > +
> > return 0;
> > }
> >
thanks for your time & comments.
Mason
CONFIDENTIALITY NOTE:
This e-mail and any attachments may contain confidential information
and/or personal data, which is protected by applicable laws. Please be
reminded that duplication, disclosure, distribution, or use of this e-mail
(and/or its attachments) or any part thereof is prohibited. If you receive
this e-mail in error, please notify us immediately and delete this mail as
well as its attachment(s) from your system. In addition, please be
informed that collection, processing, and/or use of personal data is
prohibited unless expressly permitted by personal data protection laws.
Thank you for your attention and cooperation.
Macronix International Co., Ltd.
=====================================================================
============================================================================
CONFIDENTIALITY NOTE:
This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.
Macronix International Co., Ltd.
=====================================================================
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-02-17 8:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 9:55 [PATCH v2 0/4] mtd: rawnand: Add support Macronix Block Protection & deep power down mode Mason Yang
2019-10-28 9:55 ` [PATCH v2 1/4] mtd: rawnand: Add support manufacturer specific lock/unlock operatoin Mason Yang
2019-10-30 3:22 ` kbuild test robot
2020-01-09 16:41 ` Miquel Raynal
2020-02-17 8:05 ` masonccyang
2020-01-09 19:30 ` Boris Brezillon
2020-02-17 8:14 ` masonccyang
2020-02-17 9:01 ` Miquel Raynal
2020-02-17 9:22 ` Boris Brezillon
2020-02-18 3:13 ` masonccyang
2019-10-28 9:55 ` [PATCH v2 2/4] mtd: rawnand: Add support Macronix Block Protection function Mason Yang
2020-01-09 16:47 ` Miquel Raynal
2020-02-17 8:24 ` masonccyang [this message]
2019-10-28 9:55 ` [PATCH v2 3/4] mtd: rawnand: Add support manufacturer specific suspend/resume operation Mason Yang
2019-10-30 5:56 ` kbuild test robot
2020-01-09 16:53 ` Miquel Raynal
2019-10-28 9:55 ` [PATCH v2 4/4] mtd: rawnand: Add support Macronix deep power down mode Mason Yang
2019-10-31 7:36 ` kbuild test robot
2019-10-31 7:36 ` [RFC PATCH] mtd: rawnand: nand_power_down_op() can be static kbuild test robot
2020-01-09 17:01 ` [PATCH v2 4/4] mtd: rawnand: Add support Macronix deep power down mode Miquel Raynal
2020-02-21 2:44 ` masonccyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OF29F7BCDB.FE14909F-ON48258511.002D91A4-48258511.002E31F0@mxic.com.tw \
--to=masonccyang@mxic.com.tw \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=juliensu@mxic.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).