RE: [PATCH v2 2/2] mtd: spi-nor: Add Renesas AT25QL128A serial nor flash

From: Biju Das <biju.das.jz@bp.renesas.com>
To: "Tudor.Ambarus@microchip.com" <Tudor.Ambarus@microchip.com>,
	"p.yadav@ti.com" <p.yadav@ti.com>,
	"miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
	"richard@nod.at" <richard@nod.at>,
	"vigneshr@ti.com" <vigneshr@ti.com>
Cc: "michael@walle.cc" <michael@walle.cc>,
	"Nicolas.Ferre@microchip.com" <Nicolas.Ferre@microchip.com>,
	"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
	"Claudiu.Beznea@microchip.com" <Claudiu.Beznea@microchip.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"geert+renesas@glider.be" <geert+renesas@glider.be>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	"biju.das@bp.renesas.com" <biju.das@bp.renesas.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v2 2/2] mtd: spi-nor: Add Renesas AT25QL128A serial nor flash
Date: Thu, 21 Jul 2022 09:46:31 +0000	[thread overview]
Message-ID: <OS0PR01MB59221FE257A0E06F225AB6B686919@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <785e50c4-3c8c-a1a6-de60-4587aef820a8@microchip.com>

Hi Tudor Ambarus,

Thanks for the feedback.

> Subject: Re: [PATCH v2 2/2] mtd: spi-nor: Add Renesas AT25QL128A serial nor
> flash
> 
> On 7/21/22 12:23, Biju Das wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know
> > the content is safe
> >
> > Hi Tudor Ambarus,
> >
> > I have done quick test with these generic patches. Please find my
> > observation below.
> 
> Thanks!
> 
> >
> >> Subject: Re: [PATCH v2 2/2] mtd: spi-nor: Add Renesas AT25QL128A
> >> serial nor flash
> >>
> >> On 7/15/22 13:57, Biju Das wrote:
> >>
> >> Hi, Biju!
> >>
> >>> EXTERNAL EMAIL: Do not click links or open attachments unless you
> >>> know the content is safe
> >>>
> >>> Add support for Renesas AT25QL128A serial nor flash.
> >>> Details of flash chip can be found here [1]
> >>>
> >>> [1]
> >>>
> >>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> >>> ---
> >>> $ xxd -p sfdp
> >>> 53464450060101ff00060110300000ff1f00010280000001ffffffffffff
> >>> ffffffffffffffffffffffffffffffffffffe520f1ffffffff0744eb086b
> >>> 083b80bbfeffffffffff00ffffff42eb0c200f5210d800ff3362d5008429
> >>> 01ceeca1073d7a757a75f7a2d55c19f61cffe810c080ffffffffffffffff
> >>> ffffffffffffffff501650190000ffff
> >>>
> >>> $ md5sum
> >>> /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/sp
> >>> i1 .0/spi-nor/sfdp 23e3ec56b5b8f986d0488ba4727239dd
> >>> /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/sp
> >>> i1
> >>> .0/spi-nor/sfdp $ cat
> >>> /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/sp
> >>> i1
> >>> .0/spi-nor/jedec_id
> >>> 1f4218
> >>> $ cat
> >>> /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/sp
> >>> i1
> >>> .0/spi-nor/partname
> >>> at25ql128a
> >>> $ cat
> >>> /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/sp
> >>> i1
> >>> .0/spi-nor/manufacturer
> >>> atmel
> >
> > With generic flash driver patches I get below results
> > ----------------------------------------------------
> >
> > xxd -p sfdp
> > 53464450060101ff00060110300000ff1f00010280000001ffffffffffff
> > ffffffffffffffffffffffffffffffffffffe520f1ffffffff0744eb086b
> > 083b80bbfeffffffffff00ffffff42eb0c200f5210d800ff3362d5008429
> > 01ceeca1073d7a757a75f7a2d55c19f61cffe810c080ffffffffffffffff
> > ffffffffffffffff501650190000ffff
> >
> > This result is same as above.
> 
> ok, as expected.
> 
> >
> > cat
> > /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1
> > .0/spi-nor/jedec_id
> > 1f42181f4218
> >
> > This result is not matching 1f4218->1f42181f4218
> 
> here it looks like the ID is sent twice.

OK.

> 
> >
> > root@smarc-rzg2ul:~# cat
> > /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1
> > .0/spi-nor/partname
> > spi-nor-generic
> >
> > This result is not matching at25ql128a-> spi-nor-generic
> 
> right, as expected
> 
> >
> > root@smarc-rzg2ul:~# cat
> > /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1
> > .0/spi-nor/manufacturer
> > cat:
> > /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1
> > .0/spi-nor/manufacturer: No such file or directory
> >
> > This result is not matching atmel-> cat:
> > /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1
> > .0/spi-nor/manufacturer: No such file or directory
> 
> here we could introduce a generic name as well.

OK.

Michael: Do you have any plan to add generic name for manufacturer
as completeness?

> 
> >
> > How do we get proper partname/manufacturer details with generic flash
> driver?
> 
> You don't, as it is you get just generic names like generic-spi-nor and
> generic-manufacturer. Why do you find the flash/manufacturer names
> important?

Ok, currently my test script expects proper partname/manufacturer.
Will change it to generic one.

Cheers,
Biju
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/