From: Hou Tao <houtao1@huawei.com>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: Richard Weinberger <richard@nod.at>, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 0/3] fixes for ubifs xattr operations
Date: Wed, 24 Feb 2021 10:49:07 +0800 [thread overview]
Message-ID: <a13934c9-fcc1-60cb-9169-5ee60b4cd714@huawei.com> (raw)
In-Reply-To: <CAFLxGvwVK1M6FLnkL3xbSzAx5iTWmt2j5uOxJXhWKoep16kA8Q@mail.gmail.com>
Hi,
On 11/3/2020 4:19 PM, Richard Weinberger wrote:
> On Tue, Nov 3, 2020 at 3:04 AM Hou Tao <houtao1@huawei.com> wrote:
>> Hi,
>>
>> On 2020/11/1 5:10, Richard Weinberger wrote:
>>> Tao,
>>>
>>> On Fri, Oct 23, 2020 at 9:25 AM Hou Tao <houtao1@huawei.com> wrote:
>>>> Hi Richard,
>>>>
>>>> I have written two xfstest cases [1] for these fixes three months ago, could you please
>>>> check whether the proposed solution is OK ?
>>> Thanks for your time and reminding me about this issue!
>>> I agree that this is a problem but I'm not sure whether the lockless
>>> solution is the right path to go.
>>> DId you try the locking approach?
>>>
>> Yes. Adding an extra lock for xattr ops also works. I will post a V2 soon.
> Sounds promising!
Sorry for the long delay.
> Btw. you think of an extra rw lock because host->ui_mutex is too cause
> grained and
> would block xattr parallel read operations?
Yes, the locking order is another concern. But we can change host->ui_mutex to a rw lock
if both the locking order and the granularity are OK. I will check both.
Regards,
Tao
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2021-02-24 2:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 13:04 [PATCH 0/3] fixes for ubifs xattr operations Hou Tao
2020-06-30 13:04 ` [PATCH 1/3] ubifs: check the remaining name buffer during xattr list Hou Tao
2020-06-30 13:04 ` [PATCH 2/3] ubifs: protect assertion of xattr value size by ui_mutex during xattr get Hou Tao
2020-06-30 13:04 ` [PATCH 3/3] ubifs: ensure only one in-memory xattr inode is created Hou Tao
2020-06-30 13:15 ` [PATCH 0/3] fixes for ubifs xattr operations Richard Weinberger
2020-07-01 1:11 ` Hou Tao
2020-10-23 7:19 ` Hou Tao
2020-10-31 21:10 ` Richard Weinberger
2020-11-03 2:04 ` Hou Tao
2020-11-03 8:19 ` Richard Weinberger
2021-02-24 2:49 ` Hou Tao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a13934c9-fcc1-60cb-9169-5ee60b4cd714@huawei.com \
--to=houtao1@huawei.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard.weinberger@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).