From: Vignesh Raghavendra <vigneshr@ti.com>
To: Koen Vandeputte <koen.vandeputte@ncentric.com>,
<Tudor.Ambarus@microchip.com>, <linux-mtd@lists.infradead.org>
Cc: richard@nod.at, miquel.raynal@bootlin.com
Subject: Re: [PATCH] mtd: spi-nor: add support for GigaDevice GD25D05
Date: Wed, 5 Feb 2020 11:32:11 +0530 [thread overview]
Message-ID: <bcca1846-7cd5-32f5-5345-234fccc87a76@ti.com> (raw)
In-Reply-To: <6ef35a1b-cadb-95c0-8569-0518e3dee2f4@ncentric.com>
Hi
On 04/02/20 7:40 pm, Koen Vandeputte wrote:
>
> On 14.01.20 10:13, Koen Vandeputte wrote:
>>
>> On 11.01.20 16:52, Tudor.Ambarus@microchip.com wrote:
>>> Hi, Koen,
>>>
>>> On Monday, January 6, 2020 2:46:24 PM EET Koen Vandeputte wrote:
>>>> Tested on a MikroTik RB912UAG-5HPnD r2
>>>>
>>>> [ 0.641714] m25p80 spi0.0: found gd25d05, expected m25p80
>>>> [ 0.649916] m25p80 spi0.0: gd25d05 (64 Kbytes)
>>>> [ 0.655122] Creating 4 MTD partitions on "spi0.0":
>>>> [ 0.660164] 0x000000000000-0x00000000c000 : "routerboot"
>>>> [ 0.667782] 0x00000000c000-0x00000000d000 : "hard_config"
>>>> [ 0.675073] 0x00000000d000-0x00000000e000 : "bios"
>>>> [ 0.682613] 0x00000000e000-0x00000000f000 : "soft_config"
>>> I'm afraid that this is not enough. You'll have to test all the flags
>>> that you
>>> advertised. Typically one should do a read, erase, write, read-back
>>> test, and
>>> then to exercise the lock and unlock features. If you want to be
>>> exhaustive,
>>> you can force the controller to do the reads in single, dual or quad
>>> modes,
>>> but if you choose to test just the best supported read mode, it is
>>> fine too.
>>> Please specify in the commit message what you tested.
>>>
>>> Cheers,
>>> ta
>> Hi Tudor,
>>
>> Thanks for the guidance here as it's my first patch towards this part
>> of the kernel.
>>
>> I've not only went through the datasheet of this device, but also the
>> datasheet from another very similar GD chip carrying the same specs
>> All features as indicated by the flags are clearly described in both
>> datasheets. (like, Single, Dual, Quad modes)
>>
>> The only delta is the amount of advertised blocks, and some other chip
>> package details out-of-scope from electrical performance.
>>
>> Is this clarification enough to send a V2 with a modified commit msg?
>>
Please add what modes were tested as part of commit message and respin.
BTW, there is GD25D05B and GD25D05C. Which is the flash this that you
have tested with (please add that info to commit message)?
Regards
Vignesh
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2020-02-05 6:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 12:46 [PATCH] mtd: spi-nor: add support for GigaDevice GD25D05 Koen Vandeputte
2020-01-11 15:52 ` Tudor.Ambarus
2020-01-14 9:13 ` Koen Vandeputte
2020-02-04 14:10 ` Koen Vandeputte
2020-02-05 6:02 ` Vignesh Raghavendra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcca1846-7cd5-32f5-5345-234fccc87a76@ti.com \
--to=vigneshr@ti.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=koen.vandeputte@ncentric.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).