linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: jacopo mondi <jacopo@jmondi.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Jacopo Mondi <jacopo+renesas@jmondi.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-mtd@lists.infradead.org, linux-sh@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH resend] arch/sh: mach-kfr2r09: fix struct mtd_oob_ops build warning
Date: Fri, 2 Nov 2018 09:07:01 -0700	[thread overview]
Message-ID: <bcd90d69-7487-a927-d5c1-d77c422665a8@infradead.org> (raw)
In-Reply-To: <20181102075245.GR15991@w540>

On 11/2/18 12:52 AM, jacopo mondi wrote:
> Hi Randy,
>    thanks for the patch.
> 
> On Thu, Nov 01, 2018 at 04:38:30PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> arch/sh/boards/mach-kfr2r09/setup.c does not need to #include
>> <mtd/onenand.h>, and doing so causes a build warning, so drop
>> that header file.
>>
>> In file included from ../arch/sh/boards/mach-kfr2r09/setup.c:28:
>> ../include/linux/mtd/onenand.h:225:12: warning: 'struct mtd_oob_ops' declared inside parameter list will not be visible outside of this definition or declaration
>>      struct mtd_oob_ops *ops);
>>
>> Fixes: f3590dc32974 ("media: arch: sh: kfr2r09: Use new renesas-ceu camera driver")
> 
> Not sure if this is worth pointing out, but this commit only resorts
> headers. The one introducing the warning is actually 33893d7aa.
> 
> I felt like reporting this, as introducing a "Fixes" line for that
> commit too would help backporting maybe?

Oops, thanks, I'll fix that and send a v2 with your Ack.

> In any case:
> Acked-by: Jacopo Mondi <jacopo@jmondi.org>
> 
> Thanks
>    j
> 
>>
>> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> Suggested-by: Miquel Raynal <miquel.raynal@bootlin.com>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
>> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
>> Cc: Rich Felker <dalias@libc.org>
>> Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>
>> Cc: Magnus Damm <magnus.damm@gmail.com>
>> Cc: linux-mtd@lists.infradead.org
>> Cc: linux-sh@vger.kernel.org
>> ---
>>  arch/sh/boards/mach-kfr2r09/setup.c |    1 -
>>  1 file changed, 1 deletion(-)
>>
>> --- linux-next-20181101.orig/arch/sh/boards/mach-kfr2r09/setup.c
>> +++ linux-next-20181101/arch/sh/boards/mach-kfr2r09/setup.c
>> @@ -25,7 +25,6 @@
>>  #include <linux/memblock.h>
>>  #include <linux/mfd/tmio.h>
>>  #include <linux/mmc/host.h>
>> -#include <linux/mtd/onenand.h>
>>  #include <linux/mtd/physmap.h>
>>  #include <linux/platform_data/lv5207lp.h>
>>  #include <linux/platform_device.h>
>>
>>


-- 
~Randy

      reply	other threads:[~2018-11-02 16:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01 23:38 [PATCH resend] arch/sh: mach-kfr2r09: fix struct mtd_oob_ops build warning Randy Dunlap
2018-11-02  7:52 ` jacopo mondi
2018-11-02 16:07   ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bcd90d69-7487-a927-d5c1-d77c422665a8@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=dalias@libc.org \
    --cc=geert@linux-m68k.org \
    --cc=jacopo+renesas@jmondi.org \
    --cc=jacopo@jmondi.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).