From: <Tudor.Ambarus@microchip.com>
To: <thesven73@gmail.com>
Cc: richard@nod.at, linux-mtd@lists.infradead.org, vigneshr@ti.com,
linux-kernel@vger.kernel.org, miquel.raynal@bootlin.com
Subject: Re: [PATCH v1] mtd: spi-nor: Add support for Winbond w25q64jv spi flash
Date: Mon, 29 Jun 2020 19:01:51 +0000 [thread overview]
Message-ID: <f3859642-1830-15a9-0773-0a8a2a77dfb6@microchip.com> (raw)
In-Reply-To: <CAGngYiUFh8XexBZK1U2bHcsvHS2LFAXONgLG7HhY7CDQ=LayWg@mail.gmail.com>
On 6/29/20 5:53 PM, Sven Van Asbroeck wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Hi Tudor,
>
> On Mon, Jun 29, 2020 at 8:50 AM <Tudor.Ambarus@microchip.com> wrote:
>>
>> I'm reading the following datasheet:
>> https://www.winbond.com/resource-files/w25q64jv%20revj%2003272018%20plus.pdf
>>
>> w25q64jvm (0xef7017) comes with QE bit set to a 0 state, but can be
>> set to 1, so Quad mode can be supported. Would you please set SPI_NOR_DUAL_READ
>> and SPI_NOR_QUAD_READ flags and test and see if Quad works? If all good,
>> please specify in the commit message with which controller you did the tests.
>>
>
> Good point !
>
> Unfortunately I'm using the spi controller on an imx6 ("fsl,imx51-ecspi") which
> does not support dual or quad mode. So I cannot possibly test this :)
>
> How would you like to proceed? Should I keep this as a private patch, and
> wait until someone comes along who can test this on more capable
> controller h/w ?
>
> Or should I re-spin the patch without the flags?
>
Re-spin the patch without the flags. We can add them later on, when someone can
test them.
Cheers,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2020-06-29 19:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-13 23:53 [PATCH v1] mtd: spi-nor: Add support for Winbond w25q64jv spi flash Sven Van Asbroeck
2020-06-24 17:15 ` Sven Van Asbroeck
2020-06-29 12:50 ` Tudor.Ambarus
2020-06-29 14:53 ` Sven Van Asbroeck
2020-06-29 19:01 ` Tudor.Ambarus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3859642-1830-15a9-0773-0a8a2a77dfb6@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=thesven73@gmail.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).