From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Michael Walle <mwalle@kernel.org>,
Pratyush Yadav <pratyush@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>
Cc: Ricardo Ribalda <ribalda@kernel.org>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2 5/6] mtd: spi-nor: simplify spi_nor_get_flash_info()
Date: Mon, 22 Apr 2024 11:12:05 +0100 [thread overview]
Message-ID: <f3e8b15f-bc39-4fc9-81d4-fbebef74c145@linaro.org> (raw)
In-Reply-To: <D0QK66M6GGD7.2ESAAEDMDOUUO@kernel.org>
On 4/22/24 10:53, Michael Walle wrote:
> Hi,
>
>> if (name)
>> info = spi_nor_match_name(nor, name);
>>
>> if (!info || info->id) {
here
>> jinfo = spi_nor_detect(nor);
>> if (IS_ERR(jinfo))
>> return jinfo;
>>
>> if (jinfo != info)
>
> info could be NULL here. So "info &&", apart from that looks good.
it can't be NULL, the parent if indicated above assures info isn't NULL
>
>> dev_warn(();
>> info = jinfo;
>> }
>
> Pratyush, should I'll drop your Rb tag then.
>
> -michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2024-04-22 10:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 14:12 [PATCH v2 0/6] mtd: spi-nor: spring cleaning Michael Walle
2024-04-19 14:12 ` [PATCH v2 1/6] mtd: spi-nor: Remove support for Xilinx S3AN flashes Michael Walle
2024-04-19 15:16 ` Ricardo Ribalda Delgado
2024-04-19 14:12 ` [PATCH v2 2/6] mtd: spi-nor: get rid of non-power-of-2 page size handling Michael Walle
2024-04-19 18:15 ` Pratyush Yadav
2024-04-19 14:12 ` [PATCH v2 3/6] mtd: spi-nor: remove .setup() callback Michael Walle
2024-04-22 5:55 ` Tudor Ambarus
2024-04-19 14:12 ` [PATCH v2 4/6] mtd: spi-nor: get rid of SPI_NOR_NO_FR Michael Walle
2024-04-19 18:29 ` Pratyush Yadav
2024-04-22 5:59 ` Tudor Ambarus
2024-04-19 14:12 ` [PATCH v2 5/6] mtd: spi-nor: simplify spi_nor_get_flash_info() Michael Walle
2024-04-22 6:41 ` Tudor Ambarus
2024-04-22 9:53 ` Michael Walle
2024-04-22 10:12 ` Tudor Ambarus [this message]
2024-04-22 10:14 ` Tudor Ambarus
2024-04-19 14:12 ` [PATCH v2 6/6] mtd: spi-nor: introduce support for displaying deprecation message Michael Walle
2024-04-19 18:38 ` Pratyush Yadav
2024-04-22 6:06 ` Tudor Ambarus
2024-04-22 10:00 ` Michael Walle
2024-04-22 6:42 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3e8b15f-bc39-4fc9-81d4-fbebef74c145@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=pratyush@kernel.org \
--cc=ribalda@kernel.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).