From: Qian Cai <cai@lca.pw>
To: Marco Elver <elver@google.com>, Randy Dunlap <rdunlap@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kasan-dev <kasan-dev@googlegroups.com>,
Dmitry Vyukov <dvyukov@google.com>,
"Paul E. McKenney" <paulmck@kernel.org>
Subject: Re: linux-next: Tree for Nov 19 (kcsan)
Date: Tue, 19 Nov 2019 14:02:48 -0500 [thread overview]
Message-ID: <1574190168.9585.4.camel@lca.pw> (raw)
In-Reply-To: <20191119183407.GA68739@google.com>
On Tue, 2019-11-19 at 19:34 +0100, 'Marco Elver' via kasan-dev wrote:
> On Tue, 19 Nov 2019, Randy Dunlap wrote:
>
> > On 11/19/19 8:12 AM, Marco Elver wrote:
> > > On Tue, 19 Nov 2019 at 16:11, Randy Dunlap <rdunlap@infradead.org> wrote:
> > > >
> > > > On 11/19/19 12:46 AM, Stephen Rothwell wrote:
> > > > > Hi all,
> > > > >
> > > > > Changes since 20191118:
> > > > >
> > > >
> > > > on x86_64:
> > > >
> > > > It seems that this function can already be known by the compiler as a
> > > > builtin:
> > > >
> > > > ../kernel/kcsan/core.c:619:6: warning: conflicting types for built-in function ‘__tsan_func_exit’ [-Wbuiltin-declaration-mismatch]
> > > > void __tsan_func_exit(void)
> > > > ^~~~~~~~~~~~~~~~
> > > >
> > > >
> > > > $ gcc --version
> > > > gcc (SUSE Linux) 7.4.1 20190905 [gcc-7-branch revision 275407]
> > >
> > > Interesting. Could you share the .config? So far I haven't been able
> > > to reproduce.
> >
> > Sure, it's attached.
>
> Thanks, the config did the trick, even for gcc 9.0.0.
>
> The problem is CONFIG_UBSAN=y. We haven't explicitly disallowed it like
> with KASAN. In principle there should be nothing wrong with KCSAN+UBSAN.
>
> There are 3 options:
> 1. Just disable UBSAN for KCSAN, and also disable KCSAN for UBSAN.
> 2. Restrict the config to not allow combining KCSAN and UBSAN.
> 3. Leave things as-is.
>
> Option 1 probably makes most sense, and I'll send a patch for that
> unless there are major objections.
Both option #1 and #2 sounds quite unfortunate, as UBSAN is quite valuable for
debugging. Hence, it is desire to make both work at the same time.
next prev parent reply other threads:[~2019-11-19 19:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 8:46 linux-next: Tree for Nov 19 Stephen Rothwell
2019-11-19 15:11 ` linux-next: Tree for Nov 19 (kcsan) Randy Dunlap
2019-11-19 16:12 ` Marco Elver
2019-11-19 16:50 ` Randy Dunlap
2019-11-19 18:34 ` Marco Elver
2019-11-19 18:57 ` [PATCH -next] kcsan, ubsan: Make KCSAN+UBSAN work together Marco Elver
2019-11-19 20:16 ` Paul E. McKenney
2019-11-19 21:07 ` Randy Dunlap
2019-11-19 21:17 ` Paul E. McKenney
2019-11-19 19:02 ` Qian Cai [this message]
2019-11-19 19:05 ` linux-next: Tree for Nov 19 (kcsan) Marco Elver
2019-11-19 20:14 ` Paul E. McKenney
2019-11-19 15:13 ` linux-next: Tree for Nov 19 (bpf) Randy Dunlap
2019-11-27 23:45 ` linux-next: Tree for Nov 19 (bpf/btf) Randy Dunlap
2019-11-19 15:33 ` linux-next: Tree for Nov 19 (i915) Randy Dunlap
2019-11-20 16:15 ` [Intel-gfx] " Jani Nikula
2019-11-20 16:56 ` Chris Wilson
2019-11-20 21:54 ` Randy Dunlap
2019-11-19 15:38 ` linux-next: Tree for Nov 19 (objtool) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1574190168.9585.4.camel@lca.pw \
--to=cai@lca.pw \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).