From: tony@bakeyournoodle.com (Tony Breeds)
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Jeff Garzik <jgarzik@redhat.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Linux/m68k <linux-m68k@vger.kernel.org>
Subject: Re: linux-next: Tree for May 14
Date: Fri, 16 May 2008 12:10:09 +1000 [thread overview]
Message-ID: <20080516021009.GS20457@bakeyournoodle.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0805150914220.11631@anakin>
On Thu, May 15, 2008 at 09:17:15AM +0200, Geert Uytterhoeven wrote:
> Wow, did you really get all of this from that webpage??
Sorry no. I ran the build again ... mmm cross compilers :)
> Thanks for chasing this down!
np.
> Technically, it could also happen on PPC (APUS), but all APUS support got
> removed a few months ago.
> So maybe CONFIG_ZORRO is more appropriate?
Well as it turns out it can happen in a few other plcaes (the same error
is visible on sh aswell:
http://kisskb.ellerman.id.au/kisskb/buildresult/27769/ )
Below is a new fix. Thoughts?.
From: Tony Breeds <tony@bakeyournoodle.com>
Subject: [PATCH] Fix various 8390 builds
The commit 3f8cb098859bbea29d7b3765a3102e4a6bf81b85
(drivers/net/lib8390: fix warning, trim trailing whitespace) removed
ei_local from ei_tx_err() and ei_rx_overrun() resulting in the following
build errors on m68k and sh:
Using /scratch1/tony/next as source for kernel
GEN /scratch1/tony/next_out/Makefile
CHK include/linux/version.h
CHK include/linux/utsrelease.h
CALL /scratch1/tony/next/scripts/checksyscalls.sh
CHK include/linux/compile.h
CC [M] drivers/net/zorro8390.o
In file included from /scratch1/tony/next/drivers/net/zorro8390.c:47:
drivers/net/lib8390.c: In function 'ei_tx_err':
drivers/net/lib8390.c:556: error: 'ei_local' undeclared (first use in this function)
drivers/net/lib8390.c:556: error: (Each undeclared identifier is reported only once
drivers/net/lib8390.c:556: error: for each function it appears in.)
drivers/net/lib8390.c: In function 'ei_rx_overrun':
drivers/net/lib8390.c:823: error: 'ei_local' undeclared (first use in this function)
make[3]: *** [drivers/net/zorro8390.o] Error 1
make[2]: *** [drivers/net] Error 2
make[1]: *** [drivers] Error 2
make: *** [sub-make] Error 2
The problem is that ei_inb_p() is using various #defines (from
drivers/net/8390.h) that use EI_SHIFT, which in some drivers on some
architectures use ei_local. Tag ei_local as "__maybe_unused" to keep it
around and keep the warnings the original commit is trying to silence
... silenced.
Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
---
drivers/net/lib8390.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/net/lib8390.c b/drivers/net/lib8390.c
index ed49527..fb00268 100644
--- a/drivers/net/lib8390.c
+++ b/drivers/net/lib8390.c
@@ -553,6 +553,9 @@ static void __ei_poll(struct net_device *dev)
static void ei_tx_err(struct net_device *dev)
{
unsigned long e8390_base = dev->base_addr;
+ /* ei_local is used on some platforms via the EI_SHIFT macro */
+ struct ei_device *ei_local __maybe_unused =
+ (struct ei_device *) netdev_priv(dev);
unsigned char txsr = ei_inb_p(e8390_base+EN0_TSR);
unsigned char tx_was_aborted = txsr & (ENTSR_ABT+ENTSR_FU);
@@ -815,6 +818,9 @@ static void ei_rx_overrun(struct net_device *dev)
{
unsigned long e8390_base = dev->base_addr;
unsigned char was_txing, must_resend = 0;
+ /* ei_local is used on some platforms via the EI_SHIFT macro */
+ struct ei_device *ei_local __maybe_unused =
+ (struct ei_device *) netdev_priv(dev);
/*
* Record whether a Tx was in progress and then issue the
--
1.5.5.1
next prev parent reply other threads:[~2008-05-16 2:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 7:01 linux-next: Tree for May 14 Stephen Rothwell
2008-05-14 20:38 ` Geert Uytterhoeven
2008-05-14 20:50 ` Randy Dunlap
2008-05-14 21:04 ` Tony Breeds
2008-05-15 1:05 ` Tony Breeds
2008-05-15 7:17 ` Geert Uytterhoeven
2008-05-15 7:23 ` Stephen Rothwell
2008-05-16 2:10 ` Tony Breeds [this message]
2008-05-16 7:12 ` Geert Uytterhoeven
2008-05-19 5:03 ` [PATCH v3] Fix various 8390 builds Tony Breeds
2009-05-14 6:41 linux-next: Tree for May 14 Stephen Rothwell
2009-05-14 13:17 ` Nico -telmich- Schottelius
2010-05-14 6:14 Stephen Rothwell
2012-05-14 10:03 Stephen Rothwell
2013-05-14 4:17 Stephen Rothwell
2014-05-14 8:26 Stephen Rothwell
2015-05-14 8:25 Stephen Rothwell
2018-05-14 7:20 Stephen Rothwell
2018-05-14 7:26 ` Andy Shevchenko
2018-05-14 12:40 ` Stephen Rothwell
2018-05-14 17:14 ` Andy Shevchenko
2018-05-14 21:54 ` Stephen Rothwell
2019-05-14 4:35 Stephen Rothwell
2020-05-14 11:07 Stephen Rothwell
2021-05-14 5:40 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080516021009.GS20457@bakeyournoodle.com \
--to=tony@bakeyournoodle.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=jgarzik@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).