Re: [PATCH] linux-next: Tree for May 21 - build failure with netfilter on __nf_ct_helper_find()

From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	netfilter-devel@vger.kernel.org, apw@shadowen.org
Subject: Re: [PATCH] linux-next: Tree for May 21 - build failure with netfilter on __nf_ct_helper_find()
Date: Wed, 21 May 2008 22:52:14 +1000	[thread overview]
Message-ID: <20080521225214.507eb400.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20080521113230.GA10830@linux.vnet.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 1910 bytes --]

Hi Kamalesh,

On Wed, 21 May 2008 17:02:30 +0530 Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
>
> The next-20080521 kernel build fails, on x86_64 machine 
> 
> CC net/netfilter/nf_conntrack_helper.o
> net/netfilter/nf_conntrack_helper.c: In function ‘__nf_ct_helper_find’:
> net/netfilter/nf_conntrack_helper.c:58: error: implicit declaration of function ‘hlist_for_each_entry_rcu’
> net/netfilter/nf_conntrack_helper.c:58: error: ‘hnode’ undeclared (first use in this function)
> net/netfilter/nf_conntrack_helper.c:58: error: (Each undeclared identifier is reported only once
> net/netfilter/nf_conntrack_helper.c:58: error: for each function it appears in.)
> net/netfilter/nf_conntrack_helper.c:58: error: expected ‘;’ before ‘{’ token
> net/netfilter/nf_conntrack_helper.c:50: warning: unused variable ‘mask’
> net/netfilter/nf_conntrack_helper.c: In function ‘__nf_conntrack_helper_find_byname’:
> net/netfilter/nf_conntrack_helper.c:74: error: ‘hnode’ undeclared (first use in this function)
> net/netfilter/nf_conntrack_helper.c:74: error: expected ‘;’ before ‘{’ token
> net/netfilter/nf_conntrack_helper.c: In function ‘nf_conntrack_helper_register’:
> net/netfilter/nf_conntrack_helper.c:117: error: implicit declaration of function ‘hlist_add_head_rcu’
> net/netfilter/nf_conntrack_helper.c: In function ‘nf_conntrack_helper_unregister’:
> net/netfilter/nf_conntrack_helper.c:133: error: implicit declaration of function ‘hlist_del_rcu’
> make[2]: *** [net/netfilter/nf_conntrack_helper.o] Error 1
> make[1]: *** [net/netfilter] Error 2
> make: *** [net] Error 2

Thanks for the report and patch.  This looks like it is probably broken in
Linus' kernel.  What config did you use to get the error?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]