From: Randy Dunlap <randy.dunlap@oracle.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>, corentincj@iksaif.net
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
lenb@kernel.org
Subject: [PATCH -next] eeepc: fix kconfig selects
Date: Mon, 18 May 2009 17:57:45 -0700 [thread overview]
Message-ID: <20090518175745.da1f943f.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20090518184225.d5721ac8.sfr@canb.auug.org.au>
From: Randy Dunlap <randy.dunlap@oracle.com>
EEEPC_LAPTOP selects HOTPLUG_PCI. This causes failures (build error below)
when CONFIG_HOTPLUG is not enabled, so additionally select HOTPLUG since
kconfig 'select' doesn't follow its dependency chain.
Also, only select HOTPLUG_PCI if PCI is already enabled.
drivers/pci/hotplug/fakephp.c:55: error: implicit declaration of function 'pci_rescan_bus'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/platform/x86/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-next-20090518.orig/drivers/platform/x86/Kconfig
+++ linux-next-20090518/drivers/platform/x86/Kconfig
@@ -354,7 +354,8 @@ config EEEPC_LAPTOP
select BACKLIGHT_CLASS_DEVICE
select HWMON
select RFKILL
- select HOTPLUG_PCI
+ select HOTPLUG
+ select HOTPLUG_PCI if PCI
---help---
This driver supports the Fn-Fx keys on Eee PC laptops.
It also adds the ability to switch camera/wlan on/off.
next prev parent reply other threads:[~2009-05-19 0:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 8:42 linux-next: Tree for May 18 Stephen Rothwell
2009-05-19 0:57 ` Randy Dunlap [this message]
2009-05-19 6:04 ` [PATCH -next] eeepc: fix kconfig selects Corentin Chary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090518175745.da1f943f.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=corentincj@iksaif.net \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).