From: Paul Mundt <lethal@linux-sh.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH -next] v4l2: handle unregister for non-I2C builds
Date: Fri, 22 May 2009 14:48:47 +0900 [thread overview]
Message-ID: <20090522054847.GB14059@linux-sh.org> (raw)
In-Reply-To: <4A085455.5040108@oracle.com>
On Mon, May 11, 2009 at 09:37:41AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Build fails when CONFIG_I2C=n, so handle that case in the if block:
>
> drivers/built-in.o: In function `v4l2_device_unregister':
> (.text+0x157821): undefined reference to `i2c_unregister_device'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
This patch still has not been applied as far as I can tell, and builds
are still broken as a result, almost 2 weeks after the fact.
> ---
> drivers/media/video/v4l2-device.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-next-20090511.orig/drivers/media/video/v4l2-device.c
> +++ linux-next-20090511/drivers/media/video/v4l2-device.c
> @@ -85,6 +85,7 @@ void v4l2_device_unregister(struct v4l2_
> /* Unregister subdevs */
> list_for_each_entry_safe(sd, next, &v4l2_dev->subdevs, list) {
> v4l2_device_unregister_subdev(sd);
> +#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
> if (sd->flags & V4L2_SUBDEV_FL_IS_I2C) {
> struct i2c_client *client = v4l2_get_subdevdata(sd);
>
> @@ -95,6 +96,7 @@ void v4l2_device_unregister(struct v4l2_
> if (client)
> i2c_unregister_device(client);
> }
> +#endif
> }
> }
> EXPORT_SYMBOL_GPL(v4l2_device_unregister);
>
>
> --
> ~Randy
> LPC 2009, Sept. 23-25, Portland, Oregon
> http://linuxplumbersconf.org/2009/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-05-22 5:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 6:14 linux-next: Tree for May 11 Stephen Rothwell
2009-05-11 11:46 ` Next May 11 : BUG during scsi initialization Sachin Sant
2009-05-11 11:52 ` Matthew Wilcox
2009-05-11 12:04 ` Sachin Sant
2009-05-11 12:21 ` Matthew Wilcox
2009-05-11 16:19 ` Sachin Sant
2009-05-11 16:25 ` Matthew Wilcox
2009-05-11 16:59 ` Sachin Sant
2009-05-12 4:57 ` Nick Piggin
2009-05-12 5:56 ` Stephen Rothwell
2009-05-12 5:59 ` Nick Piggin
2009-05-12 6:03 ` Stephen Rothwell
2009-05-12 6:52 ` Stephen Rothwell
2009-05-12 6:56 ` Nick Piggin
2009-05-14 8:30 ` Sachin Sant
2009-05-14 8:51 ` Pekka Enberg
2009-05-14 9:54 ` Sachin Sant
2009-05-14 9:59 ` Pekka Enberg
2009-05-14 10:01 ` Pekka Enberg
2009-05-14 11:46 ` Sachin Sant
2009-06-05 12:04 ` [Powerpc/SLQB] Next June 06 " Sachin Sant
2009-06-07 8:06 ` Pekka J Enberg
2009-06-08 12:12 ` Sachin Sant
2009-06-09 14:19 ` Nick Piggin
2009-06-12 5:44 ` Sachin Sant
2009-06-12 7:42 ` Nick Piggin
2009-06-12 8:08 ` Sachin Sant
2009-06-12 8:21 ` Nick Piggin
2009-06-12 8:25 ` Pekka Enberg
2009-06-12 8:35 ` Stephen Rothwell
2009-06-12 8:38 ` Pekka Enberg
2009-05-11 16:32 ` [PATCH -next] kvm: fix build error: add missing semi-colon Randy Dunlap
2009-05-12 8:31 ` Avi Kivity
2009-05-11 16:36 ` [PATCH -next] soc_camera: depends on I2C Randy Dunlap
2009-05-11 17:53 ` Guennadi Liakhovetski
2009-05-11 16:37 ` [PATCH -next] v4l2: handle unregister for non-I2C builds Randy Dunlap
2009-05-22 5:48 ` Paul Mundt [this message]
2009-05-22 7:55 ` Stephen Rothwell
2009-05-22 15:57 ` Randy Dunlap
2009-05-26 17:31 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090522054847.GB14059@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).