From: Sam Ravnborg <sam@ravnborg.org>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
sparclinux <sparclinux@vger.kernel.org>
Subject: sparc32 build failure [Was: linux-next: build failure after merge of the final tree]
Date: Sat, 15 Jan 2011 17:20:20 +0100 [thread overview]
Message-ID: <20110115162019.GA8136@merkur.ravnborg.org> (raw)
In-Reply-To: <20110115042753.GS9506@random.random>
On Sat, Jan 15, 2011 at 05:27:53AM +0100, Andrea Arcangeli wrote:
> Hello,
>
> On Sat, Jan 15, 2011 at 01:10:27PM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the final tree, today's linux-next build (sparc32 defconfig)
> > failed like this:
> >
> > In file included from arch/sparc/include/asm/pgtable_32.h:455,
> > from arch/sparc/include/asm/pgtable.h:6,
> > from include/linux/mm.h:41,
> > from arch/sparc/kernel/process_32.c:17:
> > include/asm-generic/pgtable.h: In function 'pmdp_get_and_clear':
> > include/asm-generic/pgtable.h:96: error: implicit declaration of function '__pmd'
> > include/asm-generic/pgtable.h:96: error: incompatible types when returning type 'int' but 'pmd_t' was expected
> >
> > and *lots* more.
> >
> > Caused by commit e2cda322648122dc400c85ada80eaddbc612ef6a ("thp: add pmd
> > mangling generic functions"). This has already been reported broken in
> > other architectures as well.
> >
> > I have just left it for today.
>
> See arch/sparc/include/asm/page_32.h
>
> /* #define __pmd(x) ((pmd_t) { (x) } ) */ /* XXX procedure with loop */
> /* #define __pmd(x) (x) */ /* XXX later */
>
>
> Not sure why __pmd is commented out on sparc32 (it isn't in sparc64,
> this is why sparc looked like building ok in a earlier report).
>
> Removing those two comments at first glance should fix the build, but
> I don't understand the comment, so I'm unsure if it's safe and what
> "XXX later" means. Overall this __pmd(0) thing is just a fake. We've
> to return some dummy pmd_t structure to build, because the function
> returns a pmd_t, there's a BUG() before __pmd is evaluated, but I
> didn't think of a better way yet than to return __pmd(0).
>
> static inline pmd_t pmdp_get_and_clear(struct mm_struct *mm,
> unsigned long
> address,
> pmd_t *pmdp)
> {
> BUG();
> return __pmd(0);
> }
Hi Andrea.
Can we get the build fixed ASAP or do we wait for David to comment on this?
Sam
next prev parent reply other threads:[~2011-01-15 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-15 2:10 linux-next: build failure after merge of the final tree Stephen Rothwell
2011-01-15 4:27 ` Andrea Arcangeli
2011-01-15 16:20 ` Sam Ravnborg [this message]
2011-01-15 18:26 ` sparc32 build failure [Was: linux-next: build failure after merge of the final tree] Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110115162019.GA8136@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=sparclinux@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).