From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Linus <torvalds@linux-foundation.org>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>,
linux-mm@kvack.org, Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Dipankar Sarma <dipankar@in.ibm.com>
Subject: linux-next: build failure after merge of the final tree
Date: Fri, 20 May 2011 16:18:16 +1000 [thread overview]
Message-ID: <20110520161816.dda6f1fd.sfr@canb.auug.org.au> (raw)
Hi all,
After merging the final tree, today's linux-next build (sparc32 defconfig)
failed like this:
mm/page_alloc.c: In function '__free_pages_bootmem':
mm/page_alloc.c:704: error: implicit declaration of function 'prefetchw'
fs/dcache.c: In function '__d_lookup_rcu':
fs/dcache.c:1810: error: implicit declaration of function 'prefetch'
fs/inode.c: In function 'new_inode':
fs/inode.c:894: error: implicit declaration of function 'spin_lock_prefetch'
net/core/skbuff.c: In function '__alloc_skb':
net/core/skbuff.c:184: error: implicit declaration of function 'prefetchw'
In file included from net/ipv4/ip_forward.c:32:
include/net/udp.h: In function 'udp_csum_outgoing':
include/net/udp.h:141: error: implicit declaration of function 'prefetch'
In file included from net/ipv6/af_inet6.c:48:
include/net/udp.h: In function 'udp_csum_outgoing':
include/net/udp.h:141: error: implicit declaration of function 'prefetch'
net/unix/af_unix.c: In function 'unix_ioctl':
net/unix/af_unix.c:2066: error: implicit declaration of function 'prefetch'
In file included from net/sunrpc/xprtsock.c:44:
include/net/udp.h: In function 'udp_csum_outgoing':
include/net/udp.h:141: error: implicit declaration of function 'prefetch'
kernel/rcutiny.c: In function 'rcu_process_callbacks':
kernel/rcutiny.c:180: error: implicit declaration of function 'prefetch'
Caused by commit e66eed651fd1 ("list: remove prefetching from regular list
iterators").
I added the following patch for today:
>From 1a101eb2766057372006b1b487d05f40fe899478 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 20 May 2011 16:08:48 +1000
Subject: [PATCH] include prefetch.h where needed
Commit e66eed651fd1 ("list: remove prefetching from regular list
iterators") removed the include of prefetch.h from list.h.
fixes these build errors on sparc:
mm/page_alloc.c: In function '__free_pages_bootmem':
mm/page_alloc.c:704: error: implicit declaration of function 'prefetchw'
fs/dcache.c: In function '__d_lookup_rcu':
fs/dcache.c:1810: error: implicit declaration of function 'prefetch'
fs/inode.c: In function 'new_inode':
fs/inode.c:894: error: implicit declaration of function 'spin_lock_prefetch'
net/core/skbuff.c: In function '__alloc_skb':
net/core/skbuff.c:184: error: implicit declaration of function 'prefetchw'
In file included from net/ipv4/ip_forward.c:32:
include/net/udp.h: In function 'udp_csum_outgoing':
include/net/udp.h:141: error: implicit declaration of function 'prefetch'
In file included from net/ipv6/af_inet6.c:48:
include/net/udp.h: In function 'udp_csum_outgoing':
include/net/udp.h:141: error: implicit declaration of function 'prefetch'
net/unix/af_unix.c: In function 'unix_ioctl':
net/unix/af_unix.c:2066: error: implicit declaration of function 'prefetch'
In file included from net/sunrpc/xprtsock.c:44:
include/net/udp.h: In function 'udp_csum_outgoing':
include/net/udp.h:141: error: implicit declaration of function 'prefetch'
kernel/rcutiny.c: In function 'rcu_process_callbacks':
kernel/rcutiny.c:180: error: implicit declaration of function 'prefetch'
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
fs/dcache.c | 1 +
fs/inode.c | 1 +
include/linux/skbuff.h | 1 +
kernel/rcutiny.c | 1 +
mm/page_alloc.c | 1 +
net/core/skbuff.c | 1 +
6 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/fs/dcache.c b/fs/dcache.c
index 22a0ef4..18b2a1f 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -35,6 +35,7 @@
#include <linux/hardirq.h>
#include <linux/bit_spinlock.h>
#include <linux/rculist_bl.h>
+#include <linux/prefetch.h>
#include "internal.h"
/*
diff --git a/fs/inode.c b/fs/inode.c
index 33c963d..c77081f 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -26,6 +26,7 @@
#include <linux/posix_acl.h>
#include <linux/ima.h>
#include <linux/cred.h>
+#include <linux/prefetch.h>
#include "internal.h"
/*
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 79aafbb..f963b8f 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -29,6 +29,7 @@
#include <linux/rcupdate.h>
#include <linux/dmaengine.h>
#include <linux/hrtimer.h>
+#include <linux/prefetch.h>
/* Don't change this without changing skb_csum_unnecessary! */
#define CHECKSUM_NONE 0
diff --git a/kernel/rcutiny.c b/kernel/rcutiny.c
index 421abfd..7bbac7d 100644
--- a/kernel/rcutiny.c
+++ b/kernel/rcutiny.c
@@ -35,6 +35,7 @@
#include <linux/init.h>
#include <linux/time.h>
#include <linux/cpu.h>
+#include <linux/prefetch.h>
/* Controls for rcu_kthread() kthread, replacing RCU_SOFTIRQ used previously. */
static struct task_struct *rcu_kthread_task;
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 44b3d7b..9d5498e 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -54,6 +54,7 @@
#include <trace/events/kmem.h>
#include <linux/ftrace_event.h>
#include <linux/memcontrol.h>
+#include <linux/prefetch.h>
#include <asm/tlbflush.h>
#include <asm/div64.h>
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 3e934fe..46cbd28 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -57,6 +57,7 @@
#include <linux/init.h>
#include <linux/scatterlist.h>
#include <linux/errqueue.h>
+#include <linux/prefetch.h>
#include <net/protocol.h>
#include <net/dst.h>
--
1.7.5.1
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
next reply other threads:[~2011-05-20 6:18 UTC|newest]
Thread overview: 185+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 6:18 Stephen Rothwell [this message]
2011-05-24 2:06 ` linux-next: build failure after merge of the final tree Mike Frysinger
2011-05-24 2:51 ` Greg KH
2011-05-24 3:59 ` Stephen Rothwell
2011-05-24 12:48 ` Greg KH
2011-05-24 21:52 ` Stephen Rothwell
2011-05-24 4:01 ` Linus Torvalds
2011-05-24 4:10 ` Mike Frysinger
2011-05-24 17:10 ` Mike Frysinger
2011-05-24 17:29 ` Linus Torvalds
2011-05-25 9:24 ` Felipe Balbi
2011-05-25 12:13 ` Mike Frysinger
-- strict thread matches above, loose matches on Subject: below --
2014-05-28 9:46 Stephen Rothwell
2014-05-28 9:57 ` Paul Bolle
2014-05-28 10:14 ` Paul Bolle
2014-05-28 20:21 ` Paul Bolle
2014-05-28 20:42 ` Greg KH
2014-05-28 20:48 ` Paul Bolle
2014-05-28 21:15 ` Greg KH
2014-05-28 10:24 ` Stephen Rothwell
2014-04-07 4:52 Stephen Rothwell
2014-04-07 18:26 ` Andrew Morton
2014-04-07 21:51 ` Stephen Rothwell
2014-01-30 3:55 Stephen Rothwell
2014-01-06 9:28 Stephen Rothwell
2014-01-06 23:12 ` Benjamin Herrenschmidt
2013-12-17 5:59 Stephen Rothwell
2013-12-17 8:26 ` Heiko Stübner
2013-12-16 5:47 Stephen Rothwell
2013-12-16 7:08 ` Krzysztof Kozlowski
2013-12-16 11:45 ` Mark Brown
2013-12-16 12:13 ` Krzysztof Kozlowski
2013-12-16 12:33 ` Mark Brown
2013-12-16 13:29 ` Stephen Rothwell
2013-11-18 3:19 Stephen Rothwell
2013-11-18 8:49 ` Kirill A. Shutemov
2013-11-18 23:09 ` David Miller
2013-11-18 3:01 Stephen Rothwell
2013-11-04 6:52 Stephen Rothwell
2013-11-04 17:06 ` Mark Brown
2013-10-29 9:16 Stephen Rothwell
2013-10-29 13:11 ` Linus Walleij
2013-10-29 13:20 ` Linus Walleij
2013-09-27 8:32 Stephen Rothwell
2013-09-27 14:40 ` Chris Ball
2013-08-20 7:20 Stephen Rothwell
2013-08-20 16:07 ` Dwight Engen
2013-08-20 19:28 ` Ben Myers
2013-08-21 0:22 ` Stephen Rothwell
2013-08-21 15:54 ` Ben Myers
2013-08-20 20:46 ` Arnd Bergmann
2013-08-21 5:08 ` Dwight Engen
2013-08-21 6:30 ` Jeremy Kerr
2013-08-21 15:56 ` Ben Myers
2013-03-12 4:30 Stephen Rothwell
2013-03-12 9:31 ` Daniel Hellstrom
2013-03-12 11:57 ` Stephen Rothwell
2013-03-12 16:13 ` Dmitry Torokhov
2013-03-13 11:20 ` Daniel Hellstrom
2013-02-06 7:30 Stephen Rothwell
2013-02-06 7:42 ` Stephen Rothwell
2013-02-06 17:52 ` Greg Kroah-Hartman
2013-02-06 18:40 ` David Miller
2012-10-16 3:50 Stephen Rothwell
2012-10-16 4:21 ` Al Viro
2012-07-31 5:14 Stephen Rothwell
2012-07-19 7:08 Stephen Rothwell
2012-07-19 13:53 ` Javier Muñoz
2012-07-05 8:33 Stephen Rothwell
2012-07-05 9:43 ` Alan Modra
2012-07-06 0:21 ` Stephen Rothwell
2012-07-06 0:57 ` Alan Modra
2012-07-06 3:01 ` Stephen Rothwell
2012-07-06 6:08 ` Alan Modra
2012-05-22 8:20 Stephen Rothwell
2012-05-22 19:05 ` David Miller
2012-05-23 2:08 ` Stephen Rothwell
2012-05-21 8:54 Stephen Rothwell
2012-05-21 9:12 ` Ingo Molnar
2012-05-21 9:15 ` Stephen Rothwell
2012-05-22 8:25 ` Stephen Rothwell
2012-05-23 15:35 ` Ingo Molnar
2012-05-24 7:16 ` Stephen Rothwell
2012-05-24 7:22 ` Ingo Molnar
2012-05-24 14:06 ` H. Peter Anvin
2012-02-27 7:06 Stephen Rothwell
2012-02-27 21:17 ` Greg KH
2012-02-27 21:24 ` Alan Cox
2012-02-27 7:05 Stephen Rothwell
2012-02-27 6:37 Stephen Rothwell
2012-02-27 9:19 ` Benjamin Herrenschmidt
2012-02-27 23:30 ` Benjamin Herrenschmidt
2012-01-20 7:21 Stephen Rothwell
2012-01-20 9:08 ` Deepthi Dharwar
2012-01-20 7:11 Stephen Rothwell
2012-01-20 7:34 ` Andrew Morton
2012-01-20 8:21 ` Sebastian Andrzej Siewior
2012-01-05 8:04 Stephen Rothwell
2012-01-06 0:04 ` Andrew Morton
2012-01-09 5:59 ` Stephen Rothwell
2012-01-09 6:20 ` Stephen Rothwell
2012-01-09 15:42 ` Greg KH
2012-01-09 15:54 ` Steven Rostedt
2012-01-09 16:27 ` Stephen Rothwell
2012-01-09 16:26 ` Stephen Rothwell
2012-01-09 21:35 ` David Miller
2012-01-09 21:41 ` Steven Rostedt
2011-12-17 4:22 Stephen Rothwell
2011-12-17 4:27 ` Stephen Rothwell
2011-09-30 1:38 Stephen Rothwell
2011-09-30 2:49 ` Yoshihiro Shimoda
2011-09-30 1:23 Stephen Rothwell
2011-09-30 1:12 Stephen Rothwell
2011-09-30 2:40 ` Paul Gortmaker
2011-09-30 3:05 ` Stephen Rothwell
2011-09-30 3:22 ` Paul Gortmaker
2011-09-30 1:05 Stephen Rothwell
2011-09-30 7:57 ` Heiko Carstens
2011-09-28 9:56 Stephen Rothwell
2011-09-28 12:02 ` huang ying
2011-08-23 5:48 Stephen Rothwell
2011-08-23 14:32 ` Randy Dunlap
2011-07-18 9:35 Stephen Rothwell
2011-07-18 9:30 Stephen Rothwell
2011-07-18 17:58 ` David Miller
2011-07-18 20:52 ` Sam Ravnborg
2011-05-27 5:11 Stephen Rothwell
2011-05-27 14:47 ` Mike Frysinger
2011-05-23 4:56 Stephen Rothwell
2011-05-23 5:17 ` Artem Bityutskiy
2011-05-20 6:32 Stephen Rothwell
2011-05-20 6:27 Stephen Rothwell
2011-05-20 6:23 Stephen Rothwell
2011-05-20 6:12 Stephen Rothwell
2011-05-20 15:24 ` Linus Torvalds
2011-05-20 16:16 ` Thomas Gleixner
2011-05-20 16:29 ` Linus Torvalds
2011-03-28 3:44 Stephen Rothwell
2011-03-24 3:30 Stephen Rothwell
2011-03-24 4:13 ` Andrew Morton
2011-03-24 19:55 ` Tony Luck
2011-01-31 6:26 Stephen Rothwell
2011-01-15 2:10 Stephen Rothwell
2011-01-15 4:27 ` Andrea Arcangeli
2010-11-29 2:07 Stephen Rothwell
2010-11-09 4:03 Stephen Rothwell
2010-09-16 5:15 Stephen Rothwell
2010-09-16 5:47 ` Takashi Iwai
2010-08-11 3:38 Stephen Rothwell
2010-08-11 5:23 ` Andrew Morton
2010-08-11 7:38 ` Stephen Rothwell
2010-07-27 7:00 Stephen Rothwell
2010-07-16 7:11 Stephen Rothwell
2010-07-16 18:39 ` Yinghai Lu
2010-07-16 20:58 ` Russell King
2010-07-16 23:07 ` Stephen Rothwell
2010-06-23 16:19 Stephen Rothwell
2010-06-24 0:36 ` Stephen Rothwell
2010-06-24 9:00 ` Catalin Marinas
2010-06-24 9:09 ` Russell King
2010-06-24 10:18 ` Phil Carmody
2010-05-25 4:10 Stephen Rothwell
2010-05-25 4:58 ` David Miller
2010-05-25 5:14 ` Herbert Xu
2010-05-25 6:56 ` David Miller
2010-05-14 5:53 Stephen Rothwell
2010-05-14 15:03 ` Don Zickus
2010-05-15 7:37 ` Ingo Molnar
2010-05-15 20:28 ` Frederic Weisbecker
2010-05-14 15:11 ` Don Zickus
2010-04-27 5:49 Stephen Rothwell
2010-04-28 9:41 ` Alexander Graf
2010-04-28 9:48 ` Avi Kivity
2010-04-28 15:21 ` Marcelo Tosatti
2010-04-08 5:35 Stephen Rothwell
2010-04-08 6:25 ` David Miller
2010-04-08 14:15 ` John Linn
2010-04-08 22:59 ` Stephen Rothwell
2010-04-08 23:01 ` John Linn
[not found] <20100318160220.b7eaded6.sfr@canb.auug.org.au>
2010-03-18 6:21 ` David Miller
[not found] <20100301203453.938e4136.sfr@canb.auug.org.au>
2010-03-01 9:42 ` Jens Axboe
2010-03-01 10:07 ` Stephen Rothwell
2010-03-01 9:40 Stephen Rothwell
2010-03-01 9:38 Stephen Rothwell
2010-03-02 20:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110520161816.dda6f1fd.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dipankar@in.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).