linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Greg KH <greg@kroah.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alan Cox <alan@linux.intel.com>
Subject: Re: linux-next: build failure after merge of the final tree (tty tree related)
Date: Thu, 26 Jul 2012 08:52:16 +1000	[thread overview]
Message-ID: <20120726085216.2ee021b6e10aebe6a853d091@canb.auug.org.au> (raw)
In-Reply-To: <20120720150237.af0d271624511fc18705f287@canb.auug.org.au>

[-- Attachment #1: Type: text/plain, Size: 2276 bytes --]

Hi Greg, Alan,

On Fri, 20 Jul 2012 15:02:37 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/usb/serial/console.c: In function 'usb_console_setup':
> drivers/usb/serial/console.c:168:16: error: invalid type argument of '->' (have 'struct ktermios')
> drivers/usb/serial/console.c:169:4: error: incompatible type for argument 1 of 'tty_termios_encode_baud_rate'
> include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument is of type 'struct ktermios'
> 
> Caused by commit adc8d746caa6 ("tty: move the termios object into the
> tty").  Hopefully this is the last of them.
> 
> I have added the following fix patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 20 Jul 2012 14:58:31 +1000
> Subject: [PATCH] tty: fix up usb serial console for termios change.
> 
> fixes these errors:
> 
> drivers/usb/serial/console.c: In function 'usb_console_setup':
> drivers/usb/serial/console.c:168:16: error: invalid type argument of '->' (have 'struct ktermios')
> drivers/usb/serial/console.c:169:4: error: incompatible type for argument 1 of 'tty_termios_encode_baud_rate'
> include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument is of type 'struct ktermios'
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/usb/serial/console.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c
> index b9cca6d..9a56428 100644
> --- a/drivers/usb/serial/console.c
> +++ b/drivers/usb/serial/console.c
> @@ -165,8 +165,8 @@ static int usb_console_setup(struct console *co, char *options)
>  		}
>  
>  		if (serial->type->set_termios) {
> -			tty->termios->c_cflag = cflag;
> -			tty_termios_encode_baud_rate(tty->termios, baud, baud);
> +			tty->termios.c_cflag = cflag;
> +			tty_termios_encode_baud_rate(&tty->termios, baud, baud);
>  			memset(&dummy, 0, sizeof(struct ktermios));
>  			serial->type->set_termios(tty, port, &dummy);
>  
> -- 
> 1.7.10.280.gaa39

Ping?
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2012-07-25 22:52 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-20  5:02 linux-next: build failure after merge of the final tree (tty tree related) Stephen Rothwell
2012-07-25 22:47 ` Greg KH
2012-07-26  0:23   ` Alan Cox
2012-07-25 22:52 ` Stephen Rothwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-10-28 14:33 Stephen Rothwell
2013-10-28 14:49 ` Michal Simek
2013-10-28 16:05 ` Sören Brinkmann
2013-10-28 16:33   ` Greg KH
2013-10-29  7:04     ` Stephen Rothwell
2013-09-27  8:21 Stephen Rothwell
2013-09-28  1:04 ` Greg KH
2013-04-02  7:57 Stephen Rothwell
2012-11-26 13:49 Stephen Rothwell
2012-11-26 14:35 ` Steven Rostedt
2012-11-26 23:05   ` Stephen Rothwell
2012-12-13 23:32     ` Stephen Rothwell
2012-12-13 23:38       ` Greg KH
2012-12-14  0:11         ` Steven Rostedt
2012-09-24 14:36 Stephen Rothwell
2012-09-25 22:41 ` Greg KH
2011-08-25  6:18 Stephen Rothwell
2011-08-25 14:08 ` Greg KH
2011-08-25 14:28   ` Timur Tabi
2011-08-25 15:22   ` Timur Tabi
2011-08-25 15:51     ` Stephen Rothwell
2011-08-25 16:09       ` Arnaud Lacombe
2011-08-26  0:39         ` Stephen Rothwell
2011-08-26 15:47           ` Arnaud Lacombe
2011-09-11  4:23             ` Stephen Rothwell
2011-09-11  9:05               ` Geert Uytterhoeven
2010-12-17  6:11 Stephen Rothwell
2010-12-17  7:04 ` Greg KH
2010-12-17 10:16   ` Thomas Gleixner
2011-01-06  3:27     ` Stephen Rothwell
2011-01-06 18:45       ` Greg KH
2010-11-12  1:57 Stephen Rothwell
2010-11-12 10:44 ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120726085216.2ee021b6e10aebe6a853d091@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=alan@linux.intel.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).