From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Xiong Zhou <jencce.kernel@gmail.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [patch v2] sound/soc/codecs : fix build failure for next-20130325
Date: Wed, 27 Mar 2013 13:39:16 +0000 [thread overview]
Message-ID: <20130327133915.GU18316@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1303272127400.26487@M2420>
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
On Wed, Mar 27, 2013 at 09:31:33PM +0800, Xiong Zhou wrote:
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 18fea10..f38af70 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -79,7 +79,6 @@ config SND_SOC_ALL_CODECS
> select SND_SOC_WM0010 if SPI_MASTER
> select SND_SOC_WM1250_EV1 if I2C
> select SND_SOC_WM2000 if I2C
> - select SND_SOC_WM2200 if I2C
> select SND_SOC_WM5100 if I2C
> select SND_SOC_WM5102 if MFD_WM5102
> select SND_SOC_WM5110 if MFD_WM5110
> @@ -370,6 +369,7 @@ config SND_SOC_WM2000
> tristate
>
> config SND_SOC_WM2200
> + depends on SND_SOC_ARIZONA && I2C
> tristate
I really don't understand this at all, removing something from
ALL_CODECS is not a good idea. This isn't a Kconfig issue.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-03-27 13:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 13:31 [patch v2] sound/soc/codecs : fix build failure for next-20130325 Xiong Zhou
2013-03-27 13:39 ` Mark Brown [this message]
2013-03-27 18:30 ` Randy Dunlap
2013-03-27 22:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327133915.GU18316@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=jencce.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).