Hi Greg, After merging the tty tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/usb/misc/sisusbvga/sisusb_con.c: In function 'sisusb_console_init': drivers/usb/misc/sisusbvga/sisusb_con.c:1493:2: error: implicit declaration of function 'take_over_console' [-Werror=implicit-function-declaration] ret = take_over_console(&sisusb_con, first - 1, last - 1, 0); ^ cc1: some warnings being treated as errors Caused by commit dc9641895abb ("vt: delete unneeded functions register_con_driver|take_over_console"). Grep is your friend! There is more to clean up here: Documentation/console/console.txt:call take_over_console() will succeed in the takeover regardless of the type Documentation/console/console.txt: take_over_console() - load and bind driver to console layer Documentation/console/console.txt:take_over_console() is now broken up into: Documentation/console/console.txt: or take_over_console(). register_con_driver() will just add the driver to Documentation/console/console.txt: console. take_over_console(), as it name implies, will also take over (or arch/alpha/kernel/console.c: take_over_console(&vga_con, 0, MAX_NR_CONSOLES-1, 1); arch/alpha/kernel/process.c: take_over_console(&dummy_con, 0, MAX_NR_CONSOLES-1, 1); arch/mips/pci/pci-bcm1480.c: take_over_console(&vga_con, 0, MAX_NR_CONSOLES-1, 1); arch/mips/pci/pci-sb1250.c: take_over_console(&vga_con, 0, MAX_NR_CONSOLES - 1, 1); arch/parisc/kernel/setup.c: conswitchp = &dummy_con; /* we use take_over_console() later ! */ drivers/tty/vt/vt.c: * take_over_console is basically a register followed by unbind drivers/usb/misc/sisusbvga/sisusb_con.c: /* This is called by take_over_console(), drivers/usb/misc/sisusbvga/sisusb_con.c: /* This is called by take_over_console() drivers/usb/misc/sisusbvga/sisusb_con.c: ret = take_over_console(&sisusb_con, first - 1, last - 1, 0); drivers/usb/misc/sisusbvga/sisusb_con.c: take_over_console(&sisusb_dummy_con, i, i, 0); drivers/usb/misc/sisusbvga/sisusb_con.c: * consoles is executed by take_over_console(). drivers/video/console/fbcon.c:/* NOTE: fbcon cannot be __init: it may be called from take_over_console later */ drivers/video/console/mdacon.c: return take_over_console(&mda_con, mda_first_vc-1, mda_last_vc-1, 0); drivers/video/console/newport_con.c:/* Can't be __init, take_over_console may call it later */ drivers/video/console/newport_con.c: return take_over_console(&newport_con, 0, MAX_NR_CONSOLES - 1, 1); drivers/video/console/sticon.c: return take_over_console(&sti_con, 0, MAX_NR_CONSOLES - 1, 1); Documentation/console/console.txt: register_con_driver() Documentation/console/console.txt: register_con_driver() Documentation/console/console.txt:1. All drivers, except system drivers, must call either register_con_driver() Documentation/console/console.txt: or take_over_console(). register_con_driver() will just add the driver to I have used the version of the tty tree from next-20130520 for today. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au