From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Waiman Long <Waiman.Long@hp.com>,
Linus <torvalds@linux-foundation.org>
Subject: linux-next: build failure after merge of the aio tree
Date: Fri, 30 Aug 2013 17:55:09 +1000 [thread overview]
Message-ID: <20130830175509.39d7fbfd96a4e726ba739d26@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1765 bytes --]
Hi Benjamin,
After merging the aio tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
In file included from include/linux/kernel.h:13:0,
from fs/aio.c:13:
fs/aio.c: In function 'aio_free_ring':
fs/aio.c:188:32: error: 'struct dentry' has no member named 'd_count'
aio_ring_file->f_path.dentry->d_count,
^
include/linux/printk.h:246:38: note: in definition of macro 'pr_debug'
no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
^
Caused by commit 36bc08cc0170 ("s/aio: Add support to aio ring pages
migration") interacting with commit 98474236f72e ("vfs: make the dentry
cache use the lockref infrastructure") from Linus' tree.
I applied the following (probably suboptimal) fix and can carry it as
necessary.
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 30 Aug 2013 17:49:10 +1000
Subject: [PATCH] aio: fixup for lockref changes
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
fs/aio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/aio.c b/fs/aio.c
index 9f783e3..6d00cd9 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -185,7 +185,7 @@ static void aio_free_ring(struct kioctx *ctx)
truncate_setsize(aio_ring_file->f_inode, 0);
pr_debug("pid(%d) i_nlink=%u d_count=%d d_unhashed=%d i_count=%d\n",
current->pid, aio_ring_file->f_inode->i_nlink,
- aio_ring_file->f_path.dentry->d_count,
+ aio_ring_file->f_path.dentry->d_lockref.count,
d_unhashed(aio_ring_file->f_path.dentry),
atomic_read(&aio_ring_file->f_inode->i_count));
fput(aio_ring_file);
--
1.8.4.rc3
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2013-08-30 7:55 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 7:55 Stephen Rothwell [this message]
2013-08-30 14:26 ` linux-next: build failure after merge of the aio tree Benjamin LaHaise
2013-08-30 17:38 ` Linus Torvalds
2013-08-30 17:42 ` Benjamin LaHaise
-- strict thread matches above, loose matches on Subject: below --
2016-03-15 6:46 Stephen Rothwell
2016-03-15 14:38 ` Andy Shevchenko
2016-03-15 16:42 ` Arnd Bergmann
2016-03-15 16:19 ` Sudip Mukherjee
2016-03-15 16:22 ` Benjamin LaHaise
2016-03-15 22:02 ` Arnd Bergmann
2016-03-16 11:12 ` Andy Shevchenko
2016-03-16 13:59 ` Arnd Bergmann
2016-03-16 14:07 ` Benjamin LaHaise
2016-01-12 5:40 Stephen Rothwell
2016-01-12 16:38 ` Benjamin LaHaise
2016-01-27 2:40 ` Stephen Rothwell
2016-01-29 11:30 ` Russell King - ARM Linux
2016-01-29 12:03 ` Geert Uytterhoeven
2016-02-04 2:19 ` Stephen Rothwell
2016-02-04 13:41 ` Benjamin LaHaise
2016-02-04 13:50 ` Russell King - ARM Linux
2016-02-04 14:08 ` Benjamin LaHaise
2016-02-04 14:12 ` Russell King - ARM Linux
2016-02-04 14:32 ` Benjamin LaHaise
2016-02-04 14:39 ` Russell King - ARM Linux
2016-02-04 16:01 ` Benjamin LaHaise
2016-02-04 16:17 ` Russell King - ARM Linux
2016-02-04 16:27 ` Benjamin LaHaise
2016-02-04 16:47 ` Benjamin LaHaise
2016-02-04 18:48 ` Benjamin LaHaise
2016-01-15 2:24 ` Stephen Rothwell
2016-01-15 7:39 ` Christoph Hellwig
2016-01-15 9:23 ` Stephen Rothwell
2016-01-15 9:25 ` Christoph Hellwig
2016-01-15 15:18 ` Benjamin LaHaise
2016-01-15 22:55 ` Stephen Rothwell
2016-03-14 4:49 ` Stephen Rothwell
2016-03-14 17:08 ` Benjamin LaHaise
2016-03-14 20:41 ` Stephen Rothwell
2013-08-21 7:45 Stephen Rothwell
2013-08-21 15:52 ` Dave Kleikamp
2013-08-21 23:53 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130830175509.39d7fbfd96a4e726ba739d26@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=Waiman.Long@hp.com \
--cc=bcrl@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).