Hi Thomas, On Mon, 31 Mar 2014 21:57:43 +1100 Stephen Rothwell wrote: > > On Mon, 31 Mar 2014 11:45:24 +0200 (CEST) Thomas Gleixner wrote: > > > > commit 8783dd3a37a5853689e1a8fa728827a50905b912 > > Author: Stephen Boyd > > Date: Tue Mar 4 16:40:30 2014 -0800 > > > > irqchip: Remove asmlinkage from static functions > > > > which is in the tip tree since March 12th. > > Thanks for that. > > An i386_defconfig produces this: > > arch/x86/kernel/syscall_32.c:14:1: warning: 'externally_visible' attribute ignored [-Wattributes] > arch/x86/kernel/machine_kexec_32.c: In function 'machine_kexec': > arch/x86/kernel/machine_kexec_32.c:191:12: warning: 'externally_visible' attribute have effect only on public objects [-Wattributes] And today from Linus' tree I get these: x86_64_allmodconfig: arch/x86/crypto/sha1_ssse3_glue.c:43:1: warning: 'externally_visible' attribute have effect only on public objects [-Wattributes] static asmlinkage void (*sha1_transform_asm)(u32 *, const char *, unsigned int); ^ arch/x86/crypto/sha256_ssse3_glue.c:56:1: warning: 'externally_visible' attribute have effect only on public objects [-Wattributes] static asmlinkage void (*sha256_transform_asm)(const char *, u32 *, u64); ^ arch/x86/crypto/sha512_ssse3_glue.c:55:1: warning: 'externally_visible' attribute have effect only on public objects [-Wattributes] static asmlinkage void (*sha512_transform_asm)(const char *, u64 *, u64); ^ arm_multi_v7_defconfig: drivers/irqchip/irq-sun4i.c:39:70: warning: 'externally_visible' attribute have effect only on public objects [-Wattributes] drivers/irqchip/irq-sun4i.c:140:1: warning: 'externally_visible' attribute have effect only on public objects [-Wattributes] drivers/irqchip/irq-armada-370-xp.c:357:1: warning: 'externally_visible' attribute have effect only on public objects [-Wattributes] drivers/irqchip/irq-gic.c:283:1: warning: 'externally_visible' attribute have effect only on public objects [-Wattributes] drivers/irqchip/irq-sirfsoc.c:51:1: warning: 'externally_visible' attribute have effect only on public objects [-Wattributes] drivers/irqchip/irq-vt8500.c:183:1: warning: 'externally_visible' attribute have effect only on public objects [-Wattributes] -- Cheers, Stephen Rothwell sfr@canb.auug.org.au