Hi Mark, After merging the spi tree, today's linux-next build (arm multi_v7_defconfig) failed like this: drivers/spi/spi-xilinx.c: In function 'xilinx_spi_probe': drivers/spi/spi-xilinx.c:391:16: warning: assignment from incompatible pointer type xspi->read_fn = ioread32; ^ drivers/spi/spi-xilinx.c:392:17: warning: assignment from incompatible pointer type xspi->write_fn = iowrite32; ^ drivers/spi/spi-xilinx.c:398:19: error: 'ioread32be' undeclared (first use in this function) xspi->read_fn = ioread32be; ^ drivers/spi/spi-xilinx.c:398:19: note: each undeclared identifier is reported only once for each function it appears in drivers/spi/spi-xilinx.c:399:20: error: 'iowrite32be' undeclared (first use in this function) xspi->write_fn = iowrite32be; ^ Caused by commit 99082eab6344 ("spi/xilinx: Remove iowrite/ioread wrappers"). Its not obvious why this is so, but reverting that commit fixed the build problem. I have reverted that commit for today. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au