Hi Andrew, After merging the akpm tree, today's linux-next build (powerpc_le perf) failed like this: bench/numa.c: In function 'bind_to_node': bench/numa.c:301:21: error: 'NUMA_NO_NODE' undeclared (first use in this function); did you mean 'NUMA_NUM_NODES'? if (target_node == NUMA_NO_NODE) { ^~~~~~~~~~~~ NUMA_NUM_NODES bench/numa.c:301:21: note: each undeclared identifier is reported only once for each function it appears in bench/numa.c: In function 'bind_to_memnode': bench/numa.c:342:14: error: 'NUMA_NO_NODE' undeclared (first use in this function); did you mean 'NUMA_NUM_NODES'? if (node == NUMA_NO_NODE) ^~~~~~~~~~~~ NUMA_NUM_NODES bench/numa.c: In function 'init_thread_data': bench/numa.c:1366:19: error: 'NUMA_NO_NODE' undeclared (first use in this function); did you mean 'NUMA_NUM_NODES'? td->bind_node = NUMA_NO_NODE; ^~~~~~~~~~~~ NUMA_NUM_NODES Caused by patch "mm: replace all open encodings for NUMA_NO_NODE" I applied the following partial revert for today: From 765f2fd3d18ca1d4d0783b888d127af784929e3e Mon Sep 17 00:00:00 2001 From: Stephen Rothwell Date: Fri, 30 Nov 2018 16:26:32 +1100 Subject: [PATCH] partial revert (perf) of "mm: replace all open encodings for NUMA_NO_NODE" Signed-off-by: Stephen Rothwell --- tools/perf/bench/numa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/bench/numa.c b/tools/perf/bench/numa.c index e0ad5f1de226..44195514b19e 100644 --- a/tools/perf/bench/numa.c +++ b/tools/perf/bench/numa.c @@ -298,7 +298,7 @@ static cpu_set_t bind_to_node(int target_node) CPU_ZERO(&mask); - if (target_node == NUMA_NO_NODE) { + if (target_node == -1) { for (cpu = 0; cpu < g->p.nr_cpus; cpu++) CPU_SET(cpu, &mask); } else { @@ -339,7 +339,7 @@ static void bind_to_memnode(int node) unsigned long nodemask; int ret; - if (node == NUMA_NO_NODE) + if (node == -1) return; BUG_ON(g->p.nr_nodes > (int)sizeof(nodemask)*8); @@ -1363,7 +1363,7 @@ static void init_thread_data(void) int cpu; /* Allow all nodes by default: */ - td->bind_node = NUMA_NO_NODE; + td->bind_node = -1; /* Allow all CPUs by default: */ CPU_ZERO(&td->bind_cpumask); -- 2.19.1 -- Cheers, Stephen Rothwell