From: Daniel Vetter <daniel@ffwll.ch>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Dave Airlie <airlied@linux.ie>,
DRI <dri-devel@lists.freedesktop.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Steve Longerbeam <slongerbeam@gmail.com>
Subject: Re: linux-next: Fixes tags need some work in the drm-fixes tree
Date: Fri, 21 Jun 2019 17:49:17 +0200 [thread overview]
Message-ID: <20190621154917.GG12905@phenom.ffwll.local> (raw)
In-Reply-To: <1561121145.3149.7.camel@pengutronix.de>
On Fri, Jun 21, 2019 at 02:45:45PM +0200, Philipp Zabel wrote:
> On Fri, 2019-06-21 at 21:41 +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> > 912bbf7e9ca4 ("gpu: ipu-v3: image-convert: Fix image downsize coefficients")
> >
> > Fixes tag
> >
> > Fixes: 70b9b6b3bcb21 ("gpu: ipu-v3: image-convert: calculate per-tile
> >
> > has these problem(s):
> >
> > - Please don't split Fixes tags across more than one line
> >
> > In commit
> >
> > bca4d70cf1b8 ("gpu: ipu-v3: image-convert: Fix input bytesperline for packed formats")
> >
> > Fixes tag
> >
> > Fixes: d966e23d61a2c ("gpu: ipu-v3: image-convert: fix bytesperline
> >
> > has these problem(s):
> >
> > - Please don't split Fixes tags across more than one line
> >
> > In commit
> >
> > ff391ecd65a1 ("gpu: ipu-v3: image-convert: Fix input bytesperline width/height align")
> >
> > Fixes tag
> >
> > Fixes: d966e23d61a2c ("gpu: ipu-v3: image-convert: fix bytesperline
> >
> > has these problem(s):
> >
> > - Please don't split Fixes tags across more than one line
> >
>
> I was under the impression that dim would have found those, but I only
> just realized that "dim checkpatch" doesn't actually do any additional
> checks beyond scripts/checkpatch.pl. Fixes tags are checked only as a
> part of "dim push". I wonder if this could be changed [1].
>
> [1] https://gitlab.freedesktop.org/drm/maintainer-tools/merge_requests/5
Officially we don't yet take pull requests (could try to change that, but
last time around it got nacked by Jani). Can you pls submit to dim-tools@
as patch?
Also, would be nice to run all the same checks we run at dim push time,
not just checking for Fixes tags.
-Daniel
>
> regards
> Philipp
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2019-06-21 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 11:41 linux-next: Fixes tags need some work in the drm-fixes tree Stephen Rothwell
2019-06-21 12:45 ` Philipp Zabel
2019-06-21 15:49 ` Daniel Vetter [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-13 10:36 Stephen Rothwell
2019-02-07 11:45 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190621154917.GG12905@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=sfr@canb.auug.org.au \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).