From: Jason Gunthorpe <jgg@mellanox.com>
To: "Kuehling, Felix" <Felix.Kuehling@amd.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
dri-devel <dri-devel@lists.freedesktop.org>,
Randy Dunlap <rdunlap@infradead.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Tree for Aug 19 (amdgpu)
Date: Wed, 21 Aug 2019 16:10:02 +0000 [thread overview]
Message-ID: <20190821160958.GH8667@mellanox.com> (raw)
In-Reply-To: <b60eb195-7263-2ba0-e8d9-8412c0de66e0@amd.com>
On Wed, Aug 21, 2019 at 03:34:12PM +0000, Kuehling, Felix wrote:
>
> On 2019-08-20 8:36 a.m., Jason Gunthorpe wrote:
> > On Tue, Aug 20, 2019 at 11:45:54AM +1000, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> On Mon, 19 Aug 2019 18:34:41 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
> >>> On 8/19/19 2:18 AM, Stephen Rothwell wrote:
> >>>> Hi all,
> >>>>
> >>>> Changes since 20190816:
> >>>>
> >>> on x86_64:
> >>>
> >>> ../drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c: In function ‘amdgpu_exit’:
> >>> ../drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:1471:2: error: implicit declaration of function ‘mmu_notifier_synchronize’; did you mean ‘__sync_synchronize’? [-Werror=implicit-function-declaration]
> >>> mmu_notifier_synchronize();
> >>> ^~~~~~~~~~~~~~~~~~~~~~~~
> >>> __sync_synchronize
> >>>
> >>>
> >>> Full randconfig file is attached.
> >> Caused by commit
> >>
> >> 6832c9dc8358 ("hmm: use mmu_notifier_get/put for 'struct hmm'")
> >>
> >> from the hmm tree.
> >>
> >> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c need to include linux/mmu_notifier.h
> > Ah yes, thanks, it is because of !CONFIG_HMM_MIRROR in this
> > randconfig. I've fixed it up.
>
> Thanks Jason. I'm trying to follow what's going on here, but I can't
> find the commit hash quoted above in any of the public repositories I'm
> tracking
I was able to squash the one line fix, so the commit ID is gone, it is
now:
https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=hmm&id=c7d8b7824ff9de866a356e1892dbe9f191aa5d06
From
https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/log/?h=hmm
Jason
next prev parent reply other threads:[~2019-08-21 16:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 9:18 linux-next: Tree for Aug 19 Stephen Rothwell
2019-08-19 21:53 ` linux-next: Tree for Aug 19 (gpu/drm/amd/display/) Randy Dunlap
2019-08-19 22:06 ` linux-next: Tree for Aug 19 (irqchip: irq-ingenic-tcu.c) Randy Dunlap
2019-08-19 22:11 ` Paul Cercueil
2019-08-20 1:34 ` linux-next: Tree for Aug 19 (amdgpu) Randy Dunlap
2019-08-20 1:45 ` Stephen Rothwell
2019-08-20 12:36 ` Jason Gunthorpe
2019-08-21 15:34 ` Kuehling, Felix
2019-08-21 16:10 ` Jason Gunthorpe [this message]
2019-08-20 1:57 ` linux-next: Tree for Aug 19 (amdgpu #2) Randy Dunlap
2019-08-20 4:16 ` linux-next: Tree for Aug 19 (drivers/net/netdevsim/dev.o) Randy Dunlap
2019-08-20 14:13 ` Ido Schimmel
2019-08-20 18:13 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821160958.GH8667@mellanox.com \
--to=jgg@mellanox.com \
--cc=Felix.Kuehling@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).