From: Greg KH <greg@kroah.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Gao Xiang <hsiangkao@aol.com>
Subject: Re: linux-next: build warning after merge of the staging tree
Date: Mon, 26 Aug 2019 08:30:24 +0200 [thread overview]
Message-ID: <20190826063024.GA1217@kroah.com> (raw)
In-Reply-To: <20190826162432.11100665@canb.auug.org.au>
On Mon, Aug 26, 2019 at 04:24:32PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> In file included from include/trace/events/erofs.h:8,
> from <command-line>:
> include/trace/events/erofs.h:28:37: warning: 'struct dentry' declared inside parameter list will not be visible outside of this definition or declaration
> TP_PROTO(struct inode *dir, struct dentry *dentry, unsigned int flags),
> ^~~~~~
> include/linux/tracepoint.h:233:34: note: in definition of macro '__DECLARE_TRACE'
> static inline void trace_##name(proto) \
> ^~~~~
> include/linux/tracepoint.h:396:24: note: in expansion of macro 'PARAMS'
> __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \
> ^~~~~~
> include/linux/tracepoint.h:532:2: note: in expansion of macro 'DECLARE_TRACE'
> DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
> ^~~~~~~~~~~~~
> include/linux/tracepoint.h:532:22: note: in expansion of macro 'PARAMS'
> DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
> ^~~~~~
> include/trace/events/erofs.h:26:1: note: in expansion of macro 'TRACE_EVENT'
> TRACE_EVENT(erofs_lookup,
> ^~~~~~~~~~~
> include/trace/events/erofs.h:28:2: note: in expansion of macro 'TP_PROTO'
> TP_PROTO(struct inode *dir, struct dentry *dentry, unsigned int flags),
> ^~~~~~~~
>
> and moany more like this ...
>
> Introduced by commit
>
> 47e4937a4a7c ("erofs: move erofs out of staging")
>
> (or, at least, exposed by it). It needs, at least, a "struct dentry;"
> added to the file.
Odd, why has this never been seen before when the same files were in
drivers/staging/ and why 0-day isn't reporting this?
Gao, can you send me a patch for this?
thanks,
greg k-h
next prev parent reply other threads:[~2019-08-26 6:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 6:24 linux-next: build warning after merge of the staging tree Stephen Rothwell
2019-08-26 6:30 ` Greg KH [this message]
2019-08-26 8:38 ` Gao Xiang
2019-08-26 8:54 ` Gao Xiang
2019-08-26 9:43 ` Gao Xiang
2019-08-26 9:53 ` Gao Xiang
2019-08-26 11:13 ` Gao Xiang
-- strict thread matches above, loose matches on Subject: below --
2020-09-09 7:16 Stephen Rothwell
2020-09-09 7:41 ` Greg KH
2019-12-13 1:10 Stephen Rothwell
2019-08-14 6:08 Stephen Rothwell
2019-08-14 7:42 ` Greg KH
2019-04-23 5:13 Stephen Rothwell
2018-11-08 2:33 Stephen Rothwell
2018-11-08 11:17 ` Greg KH
2018-09-03 2:06 Stephen Rothwell
2018-09-04 9:04 ` John Whitmore
2018-05-14 4:37 Stephen Rothwell
2018-01-16 2:45 Stephen Rothwell
2018-01-16 5:59 ` Greg KH
2018-01-16 10:47 ` Arnd Bergmann
2018-01-16 15:02 ` Greg KH
2017-01-20 4:36 Stephen Rothwell
2017-01-20 8:37 ` Greg KH
2017-01-20 9:18 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826063024.GA1217@kroah.com \
--to=greg@kroah.com \
--cc=hsiangkao@aol.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).