From: coverity-bot <keescook@chromium.org>
To: Benoit Parrot <bparrot@ti.com>
Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: ov5640_calc_pixel_rate(): Integer handling issues
Date: Mon, 28 Oct 2019 16:02:24 -0700 [thread overview]
Message-ID: <201910281602.6DD70165@keescook> (raw)
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20191025 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:
cc196e48e517 ("media: ov5640: add PIXEL_RATE control")
Coverity reported the following:
*** CID 1487375: Integer handling issues (OVERFLOW_BEFORE_WIDEN)
/drivers/media/i2c/ov5640.c: 1626 in ov5640_calc_pixel_rate()
1620 }
1621
1622 static u64 ov5640_calc_pixel_rate(struct ov5640_dev *sensor)
1623 {
1624 u64 rate;
1625
vvv CID 1487375: Integer handling issues (OVERFLOW_BEFORE_WIDEN)
vvv Potentially overflowing expression "sensor->current_mode->vtot * sensor->current_mode->htot" with type "unsigned int" (32 bits, unsigned) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "u64" (64 bits, unsigned).
1626 rate = sensor->current_mode->vtot * sensor->current_mode->htot;
1627 rate *= ov5640_framerates[sensor->current_fr];
1628
1629 return rate;
1630 }
1631
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include:
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487375 ("Integer handling issues")
Fixes: cc196e48e517 ("media: ov5640: add PIXEL_RATE control")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2019-10-28 23:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910281602.6DD70165@keescook \
--to=keescook@chromium.org \
--cc=bparrot@ti.com \
--cc=gustavo@embeddedor.com \
--cc=linux-next@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).