From: coverity-bot <keescook@chromium.org>
To: Jeroen Hofstee <jhofstee@victronenergy.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: can_rx_offload_irq_offload_timestamp(): Resource leaks
Date: Mon, 11 Nov 2019 17:35:25 -0800 [thread overview]
Message-ID: <201911111735.C0D6AFBDB@keescook> (raw)
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20191108 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:
c2a9f74c9d18 ("can: rx-offload: can_rx_offload_irq_offload_timestamp(): continue on error")
Coverity reported the following:
*** CID 1487846: Resource leaks (RESOURCE_LEAK)
/drivers/net/can/rx-offload.c: 219 in can_rx_offload_irq_offload_timestamp()
213
214 if (!(pending & BIT_ULL(i)))
215 continue;
216
217 skb = can_rx_offload_offload_one(offload, i);
218 if (IS_ERR_OR_NULL(skb))
vvv CID 1487846: Resource leaks (RESOURCE_LEAK)
vvv Variable "skb" going out of scope leaks the storage it points to.
219 continue;
220
221 __skb_queue_add_sort(&skb_queue, skb, can_rx_offload_compare);
222 }
223
224 if (!skb_queue_empty(&skb_queue)) {
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487846 ("Resource leaks")
Fixes: c2a9f74c9d18 ("can: rx-offload: can_rx_offload_irq_offload_timestamp(): continue on error")
Thanks for your attention!
--
Coverity-bot
next reply other threads:[~2019-11-12 1:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 1:35 coverity-bot [this message]
2019-11-12 8:09 ` Coverity: can_rx_offload_irq_offload_timestamp(): Resource leaks Marc Kleine-Budde
2019-11-12 21:13 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201911111735.C0D6AFBDB@keescook \
--to=keescook@chromium.org \
--cc=gustavo@embeddedor.com \
--cc=jhofstee@victronenergy.com \
--cc=linux-next@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).