From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ajay Kishore <akisho@codeaurora.org>,
Ansuel Smith <ansuelsmth@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: linux-next: build failure after merge of the pinctrl tree
Date: Mon, 30 Mar 2020 17:19:46 +1100 [thread overview]
Message-ID: <20200330171946.4e48fbd9@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 5201 bytes --]
Hi all,
After merging the pinctrl tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:
drivers/pinctrl/qcom/pinctrl-msm.c:909:4: error: expected identifier or '(' before 'else'
909 | } else {
| ^~~~
drivers/pinctrl/qcom/pinctrl-msm.c:921:2: warning: data definition has no type or storage class
921 | val = msm_readl_intr_cfg(pctrl, g);
| ^~~
drivers/pinctrl/qcom/pinctrl-msm.c:921:2: error: type defaults to 'int' in declaration of 'val' [-Werror=implicit-int]
drivers/pinctrl/qcom/pinctrl-msm.c:921:27: error: 'pctrl' undeclared here (not in a function); did you mean 'pinctrl'?
921 | val = msm_readl_intr_cfg(pctrl, g);
| ^~~~~
| pinctrl
drivers/pinctrl/qcom/pinctrl-msm.c:921:34: error: 'g' undeclared here (not in a function)
921 | val = msm_readl_intr_cfg(pctrl, g);
| ^
drivers/pinctrl/qcom/pinctrl-msm.c:922:6: error: expected '=', ',', ';', 'asm' or '__attribute__' before '|=' token
922 | val |= BIT(g->intr_raw_status_bit);
| ^~
drivers/pinctrl/qcom/pinctrl-msm.c:923:2: error: expected identifier or '(' before 'if'
923 | if (g->intr_detection_width == 2) {
| ^~
drivers/pinctrl/qcom/pinctrl-msm.c:945:4: error: expected identifier or '(' before 'else'
945 | } else if (g->intr_detection_width == 1) {
| ^~~~
drivers/pinctrl/qcom/pinctrl-msm.c:966:4: error: expected identifier or '(' before 'else'
966 | } else {
| ^~~~
drivers/pinctrl/qcom/pinctrl-msm.c:969:2: warning: data definition has no type or storage class
969 | msm_writel_intr_cfg(val, pctrl, g);
| ^~~~~~~~~~~~~~~~~~~
drivers/pinctrl/qcom/pinctrl-msm.c:969:2: error: type defaults to 'int' in declaration of 'msm_writel_intr_cfg' [-Werror=implicit-int]
drivers/pinctrl/qcom/pinctrl-msm.c:969:2: warning: parameter names (without types) in function declaration
drivers/pinctrl/qcom/pinctrl-msm.c:969:2: error: conflicting types for 'msm_writel_intr_cfg'
drivers/pinctrl/qcom/pinctrl-msm.c:84:13: note: previous definition of 'msm_writel_intr_cfg' was here
84 | static void msm_writel_##name(u32 val, struct msm_pinctrl *pctrl, \
| ^~~~~~~~~~~
drivers/pinctrl/qcom/pinctrl-msm.c:92:1: note: in expansion of macro 'MSM_ACCESSOR'
92 | MSM_ACCESSOR(intr_cfg)
| ^~~~~~~~~~~~
drivers/pinctrl/qcom/pinctrl-msm.c:971:2: error: expected identifier or '(' before 'if'
971 | if (test_bit(d->hwirq, pctrl->dual_edge_irqs))
| ^~
In file included from include/linux/vmalloc.h:5,
from include/asm-generic/io.h:887,
from arch/arm/include/asm/io.h:438,
from include/linux/io.h:13,
from drivers/pinctrl/qcom/pinctrl-msm.c:9:
include/linux/spinlock.h:287:2: error: expected identifier or '(' before 'do'
287 | do { \
| ^~
drivers/pinctrl/qcom/pinctrl-msm.c:974:2: note: in expansion of macro 'raw_spin_unlock_irqrestore'
974 | raw_spin_unlock_irqrestore(&pctrl->lock, flags);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/spinlock.h:290:4: error: expected identifier or '(' before 'while'
290 | } while (0)
| ^~~~~
drivers/pinctrl/qcom/pinctrl-msm.c:974:2: note: in expansion of macro 'raw_spin_unlock_irqrestore'
974 | raw_spin_unlock_irqrestore(&pctrl->lock, flags);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/qcom/pinctrl-msm.c:976:2: error: expected identifier or '(' before 'if'
976 | if (type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH))
| ^~
drivers/pinctrl/qcom/pinctrl-msm.c:978:2: error: expected identifier or '(' before 'else'
978 | else if (type & (IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING))
| ^~~~
drivers/pinctrl/qcom/pinctrl-msm.c:981:2: error: expected identifier or '(' before 'return'
981 | return 0;
| ^~~~~~
drivers/pinctrl/qcom/pinctrl-msm.c:982:1: error: expected identifier or '(' before '}' token
982 | }
| ^
drivers/pinctrl/qcom/pinctrl-msm.c: In function 'msm_gpio_irq_set_type':
drivers/pinctrl/qcom/pinctrl-msm.c:909:2: warning: control reaches end of non-void function [-Wreturn-type]
909 | } else {
| ^
At top level:
drivers/pinctrl/qcom/pinctrl-msm.c:84:13: warning: 'msm_writel_intr_target' defined but not used [-Wunused-function]
84 | static void msm_writel_##name(u32 val, struct msm_pinctrl *pctrl, \
| ^~~~~~~~~~~
drivers/pinctrl/qcom/pinctrl-msm.c:94:1: note: in expansion of macro 'MSM_ACCESSOR'
94 | MSM_ACCESSOR(intr_target)
| ^~~~~~~~~~~~
drivers/pinctrl/qcom/pinctrl-msm.c:79:12: warning: 'msm_readl_intr_target' defined but not used [-Wunused-function]
79 | static u32 msm_readl_##name(struct msm_pinctrl *pctrl, \
| ^~~~~~~~~~
drivers/pinctrl/qcom/pinctrl-msm.c:94:1: note: in expansion of macro 'MSM_ACCESSOR'
94 | MSM_ACCESSOR(intr_target)
| ^~~~~~~~~~~~
Caused by commit
13bec8d49bdf ("pinctrl: qcom: use scm_call to route GPIO irq to Apps")
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2020-03-30 6:19 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 6:19 Stephen Rothwell [this message]
2020-03-30 9:11 ` R: linux-next: build failure after merge of the pinctrl tree ansuelsmth
-- strict thread matches above, loose matches on Subject: below --
2023-11-14 2:13 Stephen Rothwell
2023-11-14 7:46 ` Linus Walleij
2022-11-15 4:03 Stephen Rothwell
2022-11-10 4:09 Stephen Rothwell
2022-11-10 9:14 ` Linus Walleij
2022-11-09 2:46 Stephen Rothwell
2022-11-09 3:55 ` Yinbo Zhu
2022-11-09 8:31 ` Linus Walleij
2022-08-26 5:26 Stephen Rothwell
2022-08-26 8:01 ` Linus Walleij
2022-08-26 11:20 ` Wolfram Sang
2022-08-26 13:18 ` Linus Walleij
2022-09-12 13:40 ` Uwe Kleine-König
2022-08-02 22:21 broonie
2022-08-02 22:29 ` Mario Limonciello
2022-06-29 7:13 Stephen Rothwell
2022-06-27 6:01 Stephen Rothwell
2021-10-26 5:28 Stephen Rothwell
2021-10-26 12:30 ` Prathamesh Shete
2021-10-26 20:15 ` Linus Walleij
2021-10-26 21:21 ` Dmitry Osipenko
2021-10-28 12:31 ` Prathamesh Shete
2021-11-09 4:49 ` Linus Walleij
2021-03-04 1:12 Stephen Rothwell
2021-03-04 8:16 ` Linus Walleij
2021-03-04 9:54 ` Stephen Rothwell
[not found] ` <202103050813501649431@rock-chips.com>
2021-03-05 0:43 ` Linus Walleij
[not found] ` <202103050846457413391@rock-chips.com>
2021-03-05 2:12 ` Stephen Rothwell
2021-01-27 9:41 Stephen Rothwell
2021-01-27 12:40 ` Krzysztof Kozlowski
2020-10-30 1:50 Stephen Rothwell
2020-11-04 3:10 ` Stephen Rothwell
2020-11-04 14:02 ` Linus Walleij
2020-07-17 7:16 Stephen Rothwell
2020-07-17 9:01 ` Hanks Chen
2020-07-17 11:37 ` Linus Walleij
2020-02-25 1:21 Stephen Rothwell
2020-02-25 9:14 ` Marco Felsch
2019-08-21 6:16 Stephen Rothwell
2019-08-21 7:00 ` Linus Walleij
2016-12-06 22:27 Peter Rosin
2016-12-06 22:46 ` Stephen Rothwell
2016-12-06 23:05 ` Peter Rosin
2016-12-04 23:00 Stephen Rothwell
2016-12-06 21:31 ` Stephen Rothwell
2016-12-07 14:22 ` Linus Walleij
2016-05-12 4:14 Stephen Rothwell
2016-05-12 13:39 ` Linus Walleij
2015-12-21 4:58 Stephen Rothwell
2015-12-21 6:23 ` Pramod Kumar
2015-12-21 8:44 ` Linus Walleij
2015-12-18 3:45 Stephen Rothwell
2015-12-18 5:34 ` Pramod Kumar
2015-12-18 5:57 ` Stephen Rothwell
2015-12-18 6:12 ` Pramod Kumar
2015-12-18 17:05 ` Ray Jui
2015-09-25 3:34 Stephen Rothwell
2015-10-02 3:37 ` Stephen Rothwell
2015-10-05 7:38 ` Linus Walleij
2015-01-12 5:02 Stephen Rothwell
2015-01-12 7:25 ` Linus Walleij
2014-10-27 3:35 Stephen Rothwell
2014-05-30 6:08 Stephen Rothwell
2014-05-30 8:19 ` Linus Walleij
2014-02-11 3:56 Stephen Rothwell
2014-02-11 8:21 ` Linus Walleij
2013-12-10 3:02 Stephen Rothwell
2013-12-10 4:06 ` Stephen Rothwell
2013-12-10 8:50 ` Linus Walleij
2013-12-09 4:18 Stephen Rothwell
2013-09-20 3:27 Stephen Rothwell
2012-04-04 2:44 Stephen Rothwell
2012-04-04 3:43 ` Stephen Warren
2012-04-10 7:42 ` Linus Walleij
2012-04-10 15:12 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330171946.4e48fbd9@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akisho@codeaurora.org \
--cc=ansuelsmth@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).