From: coverity-bot <keescook@chromium.org>
To: Florian Westphal <fw@strlen.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: nf_log_syslog_init(): Control flow issues
Date: Wed, 31 Mar 2021 14:59:15 -0700 [thread overview]
Message-ID: <202103311459.1514349C@keescook> (raw)
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210331 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
None
8d02e7da87a0 ("netfilter: nf_log_bridge: merge with nf_log_syslog")
Coverity reported the following:
*** CID 1503586: Control flow issues (DEADCODE)
/net/netfilter/nf_log_syslog.c: 1047 in nf_log_syslog_init()
1041 ret = nf_log_register(NFPROTO_NETDEV, &nf_netdev_logger);
1042 if (ret < 0)
1043 goto err4;
1044
1045 nf_log_register(NFPROTO_BRIDGE, &nf_bridge_logger);
1046 if (ret < 0)
vvv CID 1503586: Control flow issues (DEADCODE)
vvv Execution cannot reach this statement: "goto err5;".
1047 goto err5;
1048
1049 return 0;
1050 err5:
1051 nf_log_unregister(&nf_netdev_logger);
1052 err4:
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1503586 ("Control flow issues")
Fixes: 8d02e7da87a0 ("netfilter: nf_log_bridge: merge with nf_log_syslog")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2021-03-31 22:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103311459.1514349C@keescook \
--to=keescook@chromium.org \
--cc=fw@strlen.de \
--cc=gustavo@embeddedor.com \
--cc=linux-next@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).