Hi Jie, On Wed, 18 Aug 2021 14:54:12 +0800 Jie Deng wrote: > > On 2021/8/18 14:29, Stephen Rothwell wrote: > > Hi all, > > > > After merging the i2c tree, today's linux-next build (powerpc > > allyesconfig) produced this warning: > > > > drivers/i2c/busses/i2c-virtio.c: In function 'virtio_i2c_probe': > > drivers/i2c/busses/i2c-virtio.c:208:17: warning: unused variable 'pdev' [-Wunused-variable] > > 208 | struct device *pdev = vdev->dev.parent; > > | ^~~~ > > > > Introduced by commit > > > > 8fb12751ac78 ("i2c: virtio: add a virtio i2c frontend driver") > > Why we have this warning ? In commit 8fb12751ac78, the variable 'pdev' was used in line 237. > > https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git/commit/?h=i2c/for-next&id=8fb12751ac78d0a4ba3c604496ffc8dcd1bd6c31 > When CONFIG_ACPI is not set, ACPI_COMPANION{,_SET} do not use their arguments. -- Cheers, Stephen Rothwell