From: Stephen Rothwell <sfr@rothwell.id.au>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Networking <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: Signed-off-by missing for commit in the net tree
Date: Tue, 7 Mar 2023 11:52:52 +1100 [thread overview]
Message-ID: <20230307115252.2b23c4f5@oak.ozlabs.ibm.com> (raw)
In-Reply-To: <d5b3d530-e050-1891-e5c0-8c98e136b744@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]
Hi Heiner,
On Mon, 6 Mar 2023 23:16:09 +0100 Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> On 06.03.2023 22:37, Stephen Rothwell wrote:
> >
> > Commit
> >
> > 58aac3a2ef41 ("net: phy: smsc: fix link up detection in forced irq mode")
> >
> > is missing a Signed-off-by from its committer.
>
> Seems to be ok, false positive?
>
> net: phy: smsc: fix link up detection in forced irq mode
> Currently link up can't be detected in forced mode if polling
> isn't used. Only link up interrupt source we have is aneg
> complete which isn't applicable in forced mode. Therefore we
> have to use energy-on as link up indicator.
>
> Fixes: 7365494550f6 ("net: phy: smsc: skip ENERGYON interrupt if disabled")
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
It was committed by Jakub Kicinski <kuba@kernel.org>
$ git show --pretty=raw 58aac3a2ef41
commit 58aac3a2ef414fea6d7fdf823ea177744a087d13
tree 26bf9b3b866bd43baa1b8055d42536ac7ce3b3cf
parent 89b59a84cb166f1ab5b6de9830e61324937c661e
author Heiner Kallweit <hkallweit1@gmail.com> 1677927164 +0100
committer Jakub Kicinski <kuba@kernel.org> 1678137790 -0800
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-03-07 0:53 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 21:37 linux-next: Signed-off-by missing for commit in the net tree Stephen Rothwell
2023-03-06 22:16 ` Heiner Kallweit
2023-03-07 0:52 ` Stephen Rothwell [this message]
2023-03-07 1:32 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2024-01-01 15:26 Stephen Rothwell
2023-12-10 22:09 Stephen Rothwell
2023-05-14 22:44 Stephen Rothwell
2023-01-11 21:07 Stephen Rothwell
2022-04-25 21:53 Stephen Rothwell
2021-11-29 20:32 Stephen Rothwell
2021-11-29 20:42 ` Jason A. Donenfeld
2021-05-19 21:46 Stephen Rothwell
2021-05-05 22:14 Stephen Rothwell
2020-09-20 19:50 Stephen Rothwell
2020-05-31 17:57 Stephen Rothwell
2019-12-07 7:18 Stephen Rothwell
2019-11-17 20:11 Stephen Rothwell
2019-11-13 20:21 Stephen Rothwell
2019-11-14 8:25 ` Marc Kleine-Budde
2019-10-15 20:36 Stephen Rothwell
2019-08-05 21:38 Stephen Rothwell
2019-08-05 21:43 ` David Miller
2019-04-13 8:30 Stephen Rothwell
2019-04-13 10:34 ` David Howells
2019-03-19 5:21 Stephen Rothwell
2019-03-18 4:50 Stephen Rothwell
2019-01-11 3:48 Stephen Rothwell
2019-01-11 6:10 ` Heiner Kallweit
2019-01-11 6:27 ` Frank Wunderlich
2019-01-11 13:58 ` Andrew Lunn
2018-11-21 5:04 Stephen Rothwell
2018-11-20 5:15 Stephen Rothwell
2018-11-20 8:25 ` Xin Long
2018-11-20 17:17 ` David Miller
2018-07-04 21:49 Stephen Rothwell
2018-05-10 21:17 Stephen Rothwell
2018-05-11 1:30 ` Hangbin Liu
2018-04-29 21:18 Stephen Rothwell
2018-02-08 22:18 Stephen Rothwell
2018-02-08 3:27 Stephen Rothwell
2017-09-19 4:43 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230307115252.2b23c4f5@oak.ozlabs.ibm.com \
--to=sfr@rothwell.id.au \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).