From: Harsh Jain <harsh@chelsio.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the crypto tree
Date: Fri, 19 Jan 2018 09:51:43 +0530 [thread overview]
Message-ID: <2a629f26-de6b-803e-a07b-4cfec3b59d13@chelsio.com> (raw)
In-Reply-To: <20180119124926.1c22bb19@canb.auug.org.au>
Hi Herbert,
It's an indentation issue. Seems checkpatch and default compile options does not report this warning.
How would you like to take the fix. Should I sent whole series again with fix or only indentation patch.
On 19-01-2018 07:19, Stephen Rothwell wrote:
> Hi Herbert,
>
> After merging the crypto tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/crypto/chelsio/chcr_algo.c: In function 'create_authenc_wr':
> drivers/crypto/chelsio/chcr_algo.c:2113:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
> if (error)
> ^~
> drivers/crypto/chelsio/chcr_algo.c:2115:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
> dnents = sg_nents_xlen(req->dst, assoclen, CHCR_DST_SG_SIZE, 0);
> ^~~~~~
>
> Introduced by commit
>
> e1a018e607a3 ("crypto: chelsio - Remove dst sg size zero check")
>
next prev parent reply other threads:[~2018-01-19 4:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 1:49 linux-next: build warning after merge of the crypto tree Stephen Rothwell
2018-01-19 4:21 ` Harsh Jain [this message]
2018-01-19 5:12 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2024-02-12 3:48 Stephen Rothwell
2024-02-12 12:59 ` Cabiddu, Giovanni
2022-11-21 1:52 Stephen Rothwell
2022-07-11 10:49 Stephen Rothwell
2019-08-23 3:14 Stephen Rothwell
2019-08-25 18:01 ` Hans de Goede
2019-02-04 0:01 Stephen Rothwell
2018-10-05 5:31 Stephen Rothwell
2018-03-19 1:04 Stephen Rothwell
2018-03-19 5:44 ` Harsh Jain
2017-07-31 2:17 Stephen Rothwell
2017-07-31 13:50 ` Gary R Hook
2016-08-25 1:38 Stephen Rothwell
2016-08-25 6:20 ` Martin Schwidefsky
2016-08-25 7:47 ` Herbert Xu
2016-08-25 11:14 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a629f26-de6b-803e-a07b-4cfec3b59d13@chelsio.com \
--to=harsh@chelsio.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).