From: Sachin Sant <sachinp@in.ibm.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org
Subject: Re: Next May 13:[drivers/base/firmware*] Bug while booting on x86
Date: Fri, 15 May 2009 16:58:31 +0530 [thread overview]
Message-ID: <4A0D51DF.4020108@in.ibm.com> (raw)
In-Reply-To: <1242316467.3393.14.camel@macbook.infradead.org>
David Woodhouse wrote:
> Oops. Does this fix it?
>
> --- a/drivers/base/firmware_class.c
> +++ b/drivers/base/firmware_class.c
> @@ -328,7 +328,7 @@ firmware_data_write(struct kobject *kobj, struct
> bin_attribute *bin_attr,
>
> memcpy(page_data + page_ofs, buffer, page_cnt);
>
> - kunmap(page_data);
> + kunmap(fw_priv->pages[page_nr]);
> buffer += page_cnt;
> offset += page_cnt;
> count -= page_cnt;
Thanks David. This patch fixed the issue.
Tested-by : Sachin Sant <sachinp@in.ibm.com>
Thanks
-Sachin
--
---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------
prev parent reply other threads:[~2009-05-15 11:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 6:48 linux-next: Tree for May 13 Stephen Rothwell
2009-05-13 13:06 ` Next May 13:[drivers/base/firmware*] Bug while booting on x86 Sachin Sant
2009-05-14 5:31 ` Sachin Sant
2009-05-14 15:42 ` Sachin Sant
2009-05-14 15:54 ` David Woodhouse
2009-05-15 11:28 ` Sachin Sant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0D51DF.4020108@in.ibm.com \
--to=sachinp@in.ibm.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).