From mboxrd@z Thu Jan 1 00:00:00 1970 From: Federico Vaga Subject: Re: linux-next: build failure after merge of the net-next tree Date: Wed, 20 Jun 2012 11:59:26 +0200 Message-ID: <5059693.iaLYtpk3E4@harkonnen> References: <3170667.1PZa2330KE@harkonnen> <20120620.020611.1696375957120854262.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20120620.020611.1696375957120854262.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org To: David Miller Cc: mkl@pengutronix.de, bhupesh.sharma@st.com, sfr@canb.auug.org.au, netdev@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, giancarlo.asnaghi@st.com, wg@grandegger.com List-Id: linux-next.vger.kernel.org > Then the driver should NEVER have been submitted without the > required infrastructure in place first. This particular driver don't use the clk framework at the moment. I put that lines about clk to try to be generic as possibile, but I see that I made a mistake: I'm sorry. An alternative solution to HAVE_CLK dependency can be: remove the clk_* lines because actualy nobody use them. In the future, if our c_can migrate to clk and our clk framework is accepted in the kernel, we can re-add the clk_* lines. -- Federico Vaga