linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: David Rientjes <rientjes@google.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	Gleb Natapov <gleb@redhat.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	x86@kernel.org, linux-next@vger.kernel.org,
	linux-kernel@vger.kernel.org, KVM <kvm@vger.kernel.org>
Subject: Re: [patch] x86, kvm: fix build failure with CONFIG_SMP disabled
Date: Wed, 17 Apr 2013 17:02:07 -0700	[thread overview]
Message-ID: <516F37FF.8040703@infradead.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1304171609580.5541@chino.kir.corp.google.com>

On 04/17/13 16:12, David Rientjes wrote:
> The build fails when CONFIG_SMP is disabled:
> 
> 	arch/x86/kvm/vmx.c: In function 'vmx_deliver_posted_interrupt':
> 	arch/x86/kvm/vmx.c:3950:3: error: 'apic' undeclared (first use in this function)
> 
> Fix it by including the necessary header.

Sorry, i386 build still fails with the same error message plus this one:

ERROR: "apic" [arch/x86/kvm/kvm-intel.ko] undefined!


> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: David Rientjes <rientjes@google.com>
> ---
>  arch/x86/kvm/vmx.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -34,6 +34,7 @@
>  #include "kvm_cache_regs.h"
>  #include "x86.h"
>  
> +#include <asm/apic.h>
>  #include <asm/io.h>
>  #include <asm/desc.h>
>  #include <asm/vmx.h>
> --


-- 
~Randy

  reply	other threads:[~2013-04-18  0:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-17  7:04 linux-next: Tree for Apr 17 Stephen Rothwell
     [not found] ` <20130417170450.5dd6e5f450de4d5bf197d997-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2013-04-17 18:06   ` linux-next: Tree for Apr 17 (infiniband/rdma) Randy Dunlap
     [not found]     ` <516EE4BD.3000200-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2013-04-17 18:13       ` Roland Dreier
2013-04-17 18:15     ` Or Gerlitz
2013-04-17 18:44       ` Nicholas A. Bellinger
2013-04-17 18:10 ` linux-next: Tree for Apr 17 (kvm) Randy Dunlap
2013-04-17 22:55   ` David Rientjes
2013-04-17 23:12     ` [patch] x86, kvm: fix build failure with CONFIG_SMP disabled David Rientjes
2013-04-18  0:02       ` Randy Dunlap [this message]
2013-04-18  0:09         ` David Rientjes
2013-04-18  0:35           ` Zhang, Yang Z
2013-04-18  0:47             ` Randy Dunlap
2013-04-18  0:50               ` Zhang, Yang Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516F37FF.8040703@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=rientjes@google.com \
    --cc=sfr@canb.auug.org.au \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).