From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>, Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Subject: Re: linux-next: build warning after merge of the sound-asoc tree
Date: Fri, 29 May 2020 08:55:46 -0500 [thread overview]
Message-ID: <51d951b7-f31a-35e4-589b-a538e3a030ba@linux.intel.com> (raw)
In-Reply-To: <20200529133054.GN4610@sirena.org.uk>
On 5/29/20 8:30 AM, Mark Brown wrote:
> On Thu, May 28, 2020 at 01:57:17PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the sound-asoc tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> sound/soc/sof/intel/byt.c:464:12: warning: 'byt_remove' defined but not used [-Wunused-function]
>> 464 | static int byt_remove(struct snd_sof_dev *sdev)
>> | ^~~~~~~~~~
>> sound/soc/sof/intel/byt.c:454:12: warning: 'byt_resume' defined but not used [-Wunused-function]
>> 454 | static int byt_resume(struct snd_sof_dev *sdev)
>> | ^~~~~~~~~~
>> sound/soc/sof/intel/byt.c:447:12: warning: 'byt_suspend' defined but not used [-Wunused-function]
>> 447 | static int byt_suspend(struct snd_sof_dev *sdev, u32 target_state)
>> | ^~~~~~~~~~~
>>
>> Introduced by commits
>>
>> ddcccd543f5d ("ASoC: SOF: Intel: byt: Add PM callbacks")
>> c691f0c6e267 ("ASoC: SOF: Intel: BYT: add .remove op")
>
> Ranjani, Pierre?
Humm, I am not sure what happened here or why kbuild didn't report this
earlier. This was added in
ddcccd543f5dbd ('ASoC: SOF: Intel: byt: Add PM callbacks')
And I do see them used in the code:
sound/soc/sof/intel/byt.c
/* PM */
.suspend = byt_suspend,
.resume = byt_resume,
Will run a check and fix ASAP, my guess it's a Kconfig issue or the
functions not protected by the usual SND_SOC_SOF_BAYTRAIL.
next prev parent reply other threads:[~2020-05-29 13:55 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 3:57 linux-next: build warning after merge of the sound-asoc tree Stephen Rothwell
2020-05-29 13:30 ` Mark Brown
2020-05-29 13:55 ` Pierre-Louis Bossart [this message]
2020-05-29 14:27 ` Pierre-Louis Bossart
-- strict thread matches above, loose matches on Subject: below --
2023-12-12 0:16 Stephen Rothwell
2023-12-12 9:35 ` Charles Keepax
2023-07-13 2:16 Stephen Rothwell
2023-07-13 12:19 ` Andy Shevchenko
2023-07-13 12:41 ` Andy Shevchenko
2023-07-14 9:18 ` Andy Shevchenko
2023-07-24 3:58 ` Stephen Rothwell
2023-07-24 8:26 ` Andy Shevchenko
2023-07-24 12:36 ` Mark Brown
2023-07-24 13:05 ` Andy Shevchenko
2023-07-24 13:11 ` Mark Brown
2023-07-24 13:44 ` Andy Shevchenko
2023-07-24 15:18 ` Jonathan Corbet
2021-10-26 7:54 Stephen Rothwell
2021-08-13 2:17 Stephen Rothwell
2021-08-13 14:35 ` Doug Anderson
2021-04-19 3:41 Stephen Rothwell
2021-03-23 5:43 Stephen Rothwell
2021-03-23 6:13 ` Mukunda,Vijendar
2020-11-11 2:34 Stephen Rothwell
2020-10-02 4:14 Stephen Rothwell
2020-09-18 3:21 Stephen Rothwell
2020-09-18 9:21 ` Kai Vehmanen
2020-08-19 1:34 Stephen Rothwell
2020-04-24 6:26 Stephen Rothwell
2020-03-03 1:29 Stephen Rothwell
2020-03-01 23:57 Stephen Rothwell
2019-10-22 23:45 Stephen Rothwell
2019-10-07 23:58 Stephen Rothwell
2019-04-26 3:05 Stephen Rothwell
2019-04-26 3:14 ` Nicolin Chen
2019-04-09 1:46 Stephen Rothwell
2019-03-25 23:01 Stephen Rothwell
2019-04-08 23:12 ` Stephen Rothwell
2019-04-09 4:04 ` Annaliese McDermond
2019-03-19 23:45 Stephen Rothwell
2019-02-21 2:13 Stephen Rothwell
[not found] <CGME20190213013212epcas5p436da6762dea86287ed3aea31ef2bb830@epcas5p4.samsung.com>
2019-02-13 1:31 ` Stephen Rothwell
2019-02-13 10:35 ` Sylwester Nawrocki
2018-09-07 0:57 Stephen Rothwell
2018-08-02 4:06 Stephen Rothwell
2018-08-02 14:37 ` Mark Brown
2018-07-26 2:19 Stephen Rothwell
2018-07-26 5:58 ` Agrawal, Akshu
2018-05-10 3:09 Stephen Rothwell
2018-02-13 1:51 Stephen Rothwell
2018-02-13 2:55 ` Kuninori Morimoto
2017-11-01 4:13 Stephen Rothwell
2017-09-04 2:27 Stephen Rothwell
2017-08-23 2:20 Stephen Rothwell
2017-08-23 6:03 ` Takashi Iwai
2017-07-03 2:26 Stephen Rothwell
2017-04-27 1:29 Stephen Rothwell
2017-04-27 2:27 ` Vinod Koul
2017-02-01 2:14 Stephen Rothwell
2016-12-06 0:11 Stephen Rothwell
2015-07-13 3:23 Stephen Rothwell
2015-07-13 6:14 ` Valentin Rothberg
2015-03-19 3:45 Stephen Rothwell
2014-04-15 1:44 Stephen Rothwell
2014-02-20 3:01 Stephen Rothwell
2012-06-08 4:03 Stephen Rothwell
2012-04-05 1:03 Stephen Rothwell
2012-04-05 14:32 ` MR Swami Reddy
2012-01-09 1:55 Stephen Rothwell
2012-01-09 3:03 ` Axel Lin
2012-01-09 3:10 ` Mark Brown
2010-12-27 23:32 Stephen Rothwell
2010-12-28 9:18 ` Peter Ujfalusi
2010-08-17 2:21 Stephen Rothwell
2010-08-17 23:30 ` Liam Girdwood
2010-08-18 8:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51d951b7-f31a-35e4-589b-a538e3a030ba@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).