From: "Arend van Spriel" <arend@broadcom.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux-Next <linux-next@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
brcm80211-dev-list@broadcom.com,
linux-kbuild <linux-kbuild@vger.kernel.org>
Subject: Re: linux-next: Tree for Aug 30 (brcmfmac)
Date: Sat, 31 Aug 2013 20:21:15 +0200 [thread overview]
Message-ID: <5222341B.4070205@broadcom.com> (raw)
In-Reply-To: <CAMuHMdXFmWyiUJF+4HbD=6oGPVXHBAVx=rOC7u=motTQFCKn7g@mail.gmail.com>
On 08/31/13 19:37, Geert Uytterhoeven wrote:
> On Fri, Aug 30, 2013 at 11:12 PM, Randy Dunlap<rdunlap@infradead.org> wrote:
>> This bool kconfig symbol:
>>
>> config BRCMFMAC_SDIO
>> bool "SDIO bus interface support for FullMAC driver"
>> depends on MMC
>>
>> allows BRCMFMAC_SDIO to be y even when MMC=m.
>>
>> Is there a reasonable solution to this?
Actually, BRCMFMAC should be built in same form as the MMC and/or USB,
but only when BRCMFMAC_SDIO or BRCMFMAC_USB are selected.
So valid combinations are:
MMC=m, USB=m, BRCMFMAC_SDIO=y, BRCMFMAC_USB=y => BRCMFMAC=m
MMC=m, USB=y, BRCMFMAC_SDIO=y, BRCMFMAC_USB=y => BRCMFMAC=m
MMC=y, USB=m, BRCMFMAC_SDIO=y, BRCMFMAC_USB=y => BRCMFMAC=m
MMC=m, USB=y, BRCMFMAC_SDIO=y, BRCMFMAC_USB=n => BRCMFMAC=m
MMC=m, USB=y, BRCMFMAC_SDIO=n, BRCMFMAC_USB=y => BRCMFMAC=m|y
MMC=y, USB=m, BRCMFMAC_SDIO=y, BRCMFMAC_USB=n => BRCMFMAC=m|y
MMC=y, USB=m, BRCMFMAC_SDIO=n, BRCMFMAC_USB=y => BRCMFMAC=m
MMC=y, USB=y, BRCMFMAC_SDIO=y, BRCMFMAC_USB=y => BRCMFMAC=m|y
MMC=y, USB=y, BRCMFMAC_SDIO=y, BRCMFMAC_USB=n => BRCMFMAC=m|y
MMC=y, USB=y, BRCMFMAC_SDIO=n, BRCMFMAC_USB=y => BRCMFMAC=m|y
Not sure how to express the above.
Gr. AvS
> In order of preference:
> 1. Make it tristate
> 2. depends on MMC=y
>
> However, the first solution cannot be used as there are several
> "#ifdef CONFIG_BRCMFMAC_SDIO" in the code itself.
>
> Note that there's a similar issue with BRCMFMAC_USB and USB.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
next prev parent reply other threads:[~2013-08-31 18:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 10:00 linux-next: Tree for Aug 29 Stephen Rothwell
2013-08-29 15:25 ` linux-next: Tree for Aug 29 (xen) Randy Dunlap
2013-08-30 14:24 ` Konrad Rzeszutek Wilk
2013-08-30 19:59 ` linux-next: Tree for Aug 30 (nouveau) Randy Dunlap
2013-09-06 17:14 ` Randy Dunlap
2013-08-30 21:12 ` linux-next: Tree for Aug 30 (brcmfmac) Randy Dunlap
2013-08-31 17:37 ` Geert Uytterhoeven
2013-08-31 18:21 ` Arend van Spriel [this message]
2013-08-31 18:40 ` Hauke Mehrtens
2013-09-01 12:31 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5222341B.4070205@broadcom.com \
--to=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=geert@linux-m68k.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).