From: Michael Tokarev <mjt@tls.msk.ru>
To: Ian Kent <raven@themaw.net>
Cc: linux-next@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
autofs mailing list <autofs@vger.kernel.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/10] autofs4 - rename autofs4 to autofs
Date: Tue, 03 Sep 2013 15:28:48 +0400 [thread overview]
Message-ID: <5225C7F0.10103@msgid.tls.msk.ru> (raw)
In-Reply-To: <20130831114133.11807.35953.stgit@perseus.themaw.net>
31.08.2013 15:42, Ian Kent wrote:
[...]
> By leaving a Kconfig and Makefile in fs/autofs4 (to build autofs4.ko)
> with a deprication message sub-system maintainers and other users will
> make any needed changes before these are removed after two kernel versions.
> IMHO the presence of the warning is reason enough to leave a build stub
> rather than do a straight out rename.
Why do you want to continue building autofs4.ko? (or allowing to)
What's actually wrong with a stright rename?
If the new module can be auto-loaded by both name (by providing an
alias), there's no need to keep ability to build autofs4.ko, I think.
Well, maybe except of the case when autofs is needed in initramfs (like
for systemd). For this, indeed, you can keep autofs4.ko which is a
dummy depending on autofs.ko...
> Ian Kent (10):
> autofs4 - coding style fixes
> autofs4 - fix string.h include in auto_dev-ioctl.h
> autofs4 - move linux/auto_dev-ioctl.h to uapi/linux
> autofs - merge auto_fs.h and auto_fs4.h
> autofs - use autofs instead of autofs4 everywhere
> autofs - copy autofs4 to autofs
> autofs - create autofs Kconfig and Makefile
> autofs - update fs/autofs4/Kconfig
> autofs - update fs/autofs4/Makefile
> autofs - delete fs/autofs4
By doing it this way, you're losing all git history.
If you perform stright rename and git detects it, you
can use, eg, git log --follow to see whole hostory
across rename. This way you create new files without
history.
So I strongly shuggest actually renaming the subdirectory
(together with appropriate kconfig/makefile changes so
things are bisectable), and creating the stubs after this.
Thanks,
/mjt
next prev parent reply other threads:[~2013-09-03 11:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-31 11:42 [PATCH 00/10] autofs4 - rename autofs4 to autofs Ian Kent
2013-08-31 11:42 ` [PATCH 01/10] autofs4 - coding style fixes Ian Kent
2013-08-31 11:42 ` [PATCH 02/10] autofs4 - fix string.h include in auto_dev-ioctl.h Ian Kent
2013-08-31 11:42 ` [PATCH 03/10] autofs4 - move linux/auto_dev-ioctl.h to uapi/linux Ian Kent
2013-08-31 11:42 ` [PATCH 04/10] autofs - merge auto_fs.h and auto_fs4.h Ian Kent
2013-08-31 11:42 ` [PATCH 05/10] autofs - use autofs instead of autofs4 everywhere Ian Kent
2013-08-31 11:42 ` [PATCH 06/10] autofs - copy autofs4 to autofs Ian Kent
2013-08-31 11:42 ` [PATCH 07/10] autofs - create autofs Kconfig and Makefile Ian Kent
2013-08-31 11:43 ` [PATCH 08/10] autofs - update fs/autofs4/Kconfig Ian Kent
2013-08-31 11:43 ` [PATCH 09/10] autofs - update fs/autofs4/Makefile Ian Kent
2013-08-31 11:43 ` [PATCH 10/10] autofs - delete fs/autofs4 Ian Kent
2013-09-03 11:28 ` Michael Tokarev [this message]
2013-09-03 12:47 ` [PATCH 00/10] autofs4 - rename autofs4 to autofs Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5225C7F0.10103@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=autofs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).