linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pat Erley <pat-lkml@erley.org>
To: Richard Weinberger <richard@nod.at>
Cc: linux-next@vger.kernel.org, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: Possible regression from "fs/exec.c: call arch_pick_mmap_layout() only once"
Date: Thu, 02 Jan 2014 16:39:51 -0600	[thread overview]
Message-ID: <52C5EAB7.9030003@erley.org> (raw)
In-Reply-To: <2300703.z3jyM3yTZv@sandpuppy>

On 01/02/2014 04:24 PM, Richard Weinberger wrote:
> Am Donnerstag, 2. Januar 2014, 15:41:27 schrieb Pat Erley:
>> On my 64bit kernel, commit 283fe963095b38a6ab75dda1436ee66b9e45c7c2
>> seems to have broken 32bit compatibility.  I've run the bisection twice,
>> and verified that reverting this on HEAD fixes the problem.  I've
>> uploaded my .config to pastebin at http://pastebin.com/kVcr9H65
>>
>> Even this simple program:
>>
>> main(){puts("HELLO");}
>>
>> compiled with:
>>
>> gcc -m32 test.c
>>
>> Will crash with a segfault.  Stracing shows that it's failing to
>> allocate memory.
>
> Good catch!
>
> flush_old_exec() is called before setup_new_exec() and I've removed
> arch_pick_mmap_layout() from the second call site.
> Which turned out to be wrong.
>
> It is wrong because between both callers current->personality is changed.
> So, we have to remove the first call to arch_pick_mmap_layout() and keep the
> latter because only then the correct personality is set up.
>
> Can you please test your config with the following patch applied and having
> 283fe96 reverted?
>
> If it works out for you I'd send an updated patch to Andrew.
> In the meanwhile I'll double check all call sites...
>
> Thanks,
> //richard
>
> ---
> diff --git a/fs/exec.c b/fs/exec.c
> index 7ea097f..a733599 100644
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -843,7 +843,6 @@ static int exec_mmap(struct mm_struct *mm)
>   	tsk->active_mm = mm;
>   	activate_mm(active_mm, mm);
>   	task_unlock(tsk);
> -	arch_pick_mmap_layout(mm);
>   	if (old_mm) {
>   		up_read(&old_mm->mmap_sem);
>   		BUG_ON(active_mm != old_mm);
>

Compiling right now.  Will test later tonight and let you know.

Pat

  reply	other threads:[~2014-01-02 22:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-02 21:41 Possible regression from "fs/exec.c: call arch_pick_mmap_layout() only once" Pat Erley
2014-01-02 22:24 ` Richard Weinberger
2014-01-02 22:39   ` Pat Erley [this message]
2014-01-03  4:35     ` Pat Erley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52C5EAB7.9030003@erley.org \
    --to=pat-lkml@erley.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).