From: Randy Dunlap <rdunlap@infradead.org>
To: Danil Kipnis <danil.kipnis@cloud.ionos.com>,
linux-block@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-next@vger.kernel.org, axboe@kernel.dk, dledford@redhat.com,
jgg@ziepe.ca
Cc: bvanassche@acm.org, leon@kernel.org, jinpu.wang@cloud.ionos.com
Subject: Re: [PATCH v2] rnbd/rtrs: pass max segment size from blk user to the rdma library
Date: Tue, 19 May 2020 08:04:05 -0700 [thread overview]
Message-ID: <63d61bce-afe4-5af7-d181-7380db9a701d@infradead.org> (raw)
In-Reply-To: <20200519111419.924170-1-danil.kipnis@cloud.ionos.com>
On 5/19/20 4:14 AM, Danil Kipnis wrote:
> When Block Device Layer is disabled, BLK_MAX_SEGMENT_SIZE is undefined.
> The rtrs is a transport library and should compile independently of the
> block layer. The desired max segment size should be passed down by the
> user.
>
> Introduce max_segment_size parameter for the rtrs_clt_open() call.
>
> Fixes: f7a7a5c228d4 ("block/rnbd: client: main functionality")
> Fixes: 6a98d71daea1 ("RDMA/rtrs: client: main functionality")
> Fixes: cb80329c9434 ("RDMA/rtrs: client: private header with client structs and functions")
> Fixes: b5c27cdb094e ("RDMA/rtrs: public interface header to establish RDMA connections")
>
> Signed-off-by: Danil Kipnis <danil.kipnis@cloud.ionos.com>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> v1->v2 Add Fixes lines.
>
> drivers/block/rnbd/rnbd-clt.c | 1 +
> drivers/infiniband/ulp/rtrs/rtrs-clt.c | 17 +++++++++++------
> drivers/infiniband/ulp/rtrs/rtrs-clt.h | 1 +
> drivers/infiniband/ulp/rtrs/rtrs.h | 1 +
> 4 files changed, 14 insertions(+), 6 deletions(-)
--
~Randy
next prev parent reply other threads:[~2020-05-19 15:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 10:57 linux-next: Tree for May 18 Stephen Rothwell
2020-05-18 15:00 ` linux-next: Tree for May 18 (drivers/infiniband/ulp/rtrs/rtrs-clt.c) Randy Dunlap
2020-05-19 6:55 ` Danil Kipnis
2020-05-19 8:01 ` [PATCH 0/1] Fix RTRS compilation with block layer disabled Danil Kipnis
2020-05-19 8:01 ` [PATCH 1/1] rnbd/rtrs: pass max segment size from blk user to the rdma library Danil Kipnis
2020-05-19 8:48 ` Leon Romanovsky
2020-05-19 9:14 ` Danil Kipnis
2020-05-19 15:42 ` Leon Romanovsky
2020-05-19 11:14 ` [PATCH v2] " Danil Kipnis
2020-05-19 15:04 ` Randy Dunlap [this message]
2020-05-19 23:44 ` Jason Gunthorpe
2020-05-21 16:12 ` Randy Dunlap
2020-05-21 20:00 ` Jason Gunthorpe
2020-05-19 8:45 ` [PATCH 0/1] Fix RTRS compilation with block layer disabled Leon Romanovsky
2020-05-19 23:34 ` Jason Gunthorpe
2020-05-18 15:42 ` linux-next: Tree for May 18 (input/misc/iqs269a.c & regmap) Randy Dunlap
2020-05-18 16:20 ` Jeff LaBundy
2020-05-22 18:22 ` Randy Dunlap
2020-05-22 21:49 ` Dmitry Torokhov
2020-05-18 16:41 ` linux-next: Tree for May 18 (x86/mm/pgtable.c) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63d61bce-afe4-5af7-d181-7380db9a701d@infradead.org \
--to=rdunlap@infradead.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=danil.kipnis@cloud.ionos.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jinpu.wang@cloud.ionos.com \
--cc=leon@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).