From: Eric DeVolder <eric.devolder@oracle.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Sourabh Jain <sourabhjain@linux.ibm.com>
Subject: Re: linux-next: build failure after merge of the mm tree
Date: Tue, 8 Aug 2023 10:20:34 -0500 [thread overview]
Message-ID: <7c71182b-f7f1-e14b-4c65-f2c78ca58d1c@oracle.com> (raw)
In-Reply-To: <20230808144020.538cdab8@canb.auug.org.au>
I'm looking at this, turns out PROC_KCORE selects CRASH_CORE, which according to the original config
settings, does not pickup KEXEC_CORE. So I'm looking at closing that gap.
eric
On 8/7/23 23:40, Stephen Rothwell wrote:
> Hi all,
>
> After merging the mm tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
>
> In file included from kernel/crash_core.c:23:
> kernel/kexec_internal.h:11:54: warning: 'struct kexec_segment' declared inside parameter list will not be visible outside of this definition or declaration
> 11 | int kimage_load_segment(struct kimage *image, struct kexec_segment *segment);
> | ^~~~~~~~~~~~~
> kernel/crash_core.c:321:40: warning: 'struct crash_mem' declared inside parameter list will not be visible outside of this definition or declaration
> 321 | int crash_prepare_elf64_headers(struct crash_mem *mem, int need_kernel_map,
> | ^~~~~~~~~
> kernel/crash_core.c: In function 'crash_prepare_elf64_headers':
> kernel/crash_core.c:334:23: error: invalid use of undefined type 'struct crash_mem'
> 334 | nr_phdr += mem->nr_ranges;
> | ^~
> In file included from include/vdso/const.h:5,
> from include/linux/const.h:4,
> from include/linux/bits.h:5,
> from include/linux/ratelimit_types.h:5,
> from include/linux/printk.h:9,
> from include/asm-generic/bug.h:22,
> from arch/powerpc/include/asm/bug.h:116,
> from include/linux/bug.h:5,
> from arch/powerpc/include/asm/cmpxchg.h:8,
> from arch/powerpc/include/asm/atomic.h:11,
> from include/linux/atomic.h:7,
> from include/linux/mm_types_task.h:13,
> from include/linux/mm_types.h:5,
> from include/linux/buildid.h:5,
> from kernel/crash_core.c:7:
> kernel/crash_core.c:346:32: error: 'ELF_CORE_HEADER_ALIGN' undeclared (first use in this function)
> 346 | elf_sz = ALIGN(elf_sz, ELF_CORE_HEADER_ALIGN);
> | ^~~~~~~~~~~~~~~~~~~~~
> include/uapi/linux/const.h:32:50: note: in definition of macro '__ALIGN_KERNEL_MASK'
> 32 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask))
> | ^~~~
> include/linux/align.h:8:33: note: in expansion of macro '__ALIGN_KERNEL'
> 8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
> | ^~~~~~~~~~~~~~
> kernel/crash_core.c:346:18: note: in expansion of macro 'ALIGN'
> 346 | elf_sz = ALIGN(elf_sz, ELF_CORE_HEADER_ALIGN);
> | ^~~~~
> kernel/crash_core.c:346:32: note: each undeclared identifier is reported only once for each function it appears in
> 346 | elf_sz = ALIGN(elf_sz, ELF_CORE_HEADER_ALIGN);
> | ^~~~~~~~~~~~~~~~~~~~~
> include/uapi/linux/const.h:32:50: note: in definition of macro '__ALIGN_KERNEL_MASK'
> 32 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask))
> | ^~~~
> include/linux/align.h:8:33: note: in expansion of macro '__ALIGN_KERNEL'
> 8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a))
> | ^~~~~~~~~~~~~~
> kernel/crash_core.c:346:18: note: in expansion of macro 'ALIGN'
> 346 | elf_sz = ALIGN(elf_sz, ELF_CORE_HEADER_ALIGN);
> | ^~~~~
> kernel/crash_core.c:396:28: error: invalid use of undefined type 'struct crash_mem'
> 396 | for (i = 0; i < mem->nr_ranges; i++) {
> | ^~
> kernel/crash_core.c:397:29: error: invalid use of undefined type 'struct crash_mem'
> 397 | mstart = mem->ranges[i].start;
> | ^~
> kernel/crash_core.c:398:27: error: invalid use of undefined type 'struct crash_mem'
> 398 | mend = mem->ranges[i].end;
> | ^~
> kernel/crash_core.c: At top level:
> kernel/crash_core.c:420:36: warning: 'struct crash_mem' declared inside parameter list will not be visible outside of this definition or declaration
> 420 | int crash_exclude_mem_range(struct crash_mem *mem,
> | ^~~~~~~~~
> kernel/crash_core.c: In function 'crash_exclude_mem_range':
> kernel/crash_core.c:427:28: error: invalid use of undefined type 'struct crash_mem'
> 427 | for (i = 0; i < mem->nr_ranges; i++) {
> | ^~
> kernel/crash_core.c:428:28: error: invalid use of undefined type 'struct crash_mem'
> 428 | start = mem->ranges[i].start;
> | ^~
> kernel/crash_core.c:429:26: error: invalid use of undefined type 'struct crash_mem'
> 429 | end = mem->ranges[i].end;
> | ^~
> kernel/crash_core.c:444:28: error: invalid use of undefined type 'struct crash_mem'
> 444 | mem->ranges[i].start = 0;
> | ^~
> kernel/crash_core.c:445:28: error: invalid use of undefined type 'struct crash_mem'
> 445 | mem->ranges[i].end = 0;
> | ^~
> kernel/crash_core.c:446:36: error: invalid use of undefined type 'struct crash_mem'
> 446 | if (i < mem->nr_ranges - 1) {
> | ^~
> kernel/crash_core.c:448:52: error: invalid use of undefined type 'struct crash_mem'
> 448 | for (j = i; j < mem->nr_ranges - 1; j++) {
> | ^~
> kernel/crash_core.c:449:44: error: invalid use of undefined type 'struct crash_mem'
> 449 | mem->ranges[j].start =
> | ^~
> kernel/crash_core.c:450:52: error: invalid use of undefined type 'struct crash_mem'
> 450 | mem->ranges[j+1].start;
> | ^~
> kernel/crash_core.c:451:44: error: invalid use of undefined type 'struct crash_mem'
> 451 | mem->ranges[j].end =
> | ^~
> kernel/crash_core.c:452:60: error: invalid use of undefined type 'struct crash_mem'
> 452 | mem->ranges[j+1].end;
> | ^~
> kernel/crash_core.c:461:36: error: invalid use of undefined type 'struct crash_mem'
> 461 | mem->nr_ranges--;
> | ^~
> kernel/crash_core.c:464:28: error: invalid use of undefined type 'struct crash_mem'
> 464 | mem->nr_ranges--;
> | ^~
> kernel/crash_core.c:470:28: error: invalid use of undefined type 'struct crash_mem'
> 470 | mem->ranges[i].end = p_start - 1;
> | ^~
> kernel/crash_core.c:474:28: error: invalid use of undefined type 'struct crash_mem'
> 474 | mem->ranges[i].end = p_start - 1;
> | ^~
> kernel/crash_core.c:476:28: error: invalid use of undefined type 'struct crash_mem'
> 476 | mem->ranges[i].start = p_end + 1;
> | ^~
> kernel/crash_core.c:485:21: error: invalid use of undefined type 'struct crash_mem'
> 485 | if (i == mem->max_nr_ranges - 1)
> | ^~
> kernel/crash_core.c:490:20: error: invalid use of undefined type 'struct crash_mem'
> 490 | if (j < mem->nr_ranges) {
> | ^~
> kernel/crash_core.c:492:29: error: invalid use of undefined type 'struct crash_mem'
> 492 | for (i = mem->nr_ranges - 1; i >= j; i--)
> | ^~
> kernel/crash_core.c:493:28: error: invalid use of undefined type 'struct crash_mem'
> 493 | mem->ranges[i + 1] = mem->ranges[i];
> | ^~
> kernel/crash_core.c:493:49: error: invalid use of undefined type 'struct crash_mem'
> 493 | mem->ranges[i + 1] = mem->ranges[i];
> | ^~
> kernel/crash_core.c:496:12: error: invalid use of undefined type 'struct crash_mem'
> 496 | mem->ranges[j].start = temp_range.start;
> | ^~
> kernel/crash_core.c:497:12: error: invalid use of undefined type 'struct crash_mem'
> 497 | mem->ranges[j].end = temp_range.end;
> | ^~
> kernel/crash_core.c:498:12: error: invalid use of undefined type 'struct crash_mem'
> 498 | mem->nr_ranges++;
> | ^~
>
> I am not sure exactly which commit caused but I have revreted these
> for today:
>
> 6a41fd4665e6 ("x86/crash: optimize CPU changes")
> add3b7e011e9 ("crash: change crash_prepare_elf64_headers() to for_each_possible_cpu()")
> 4a7eed40a7bc ("crash: hotplug support for kexec_load()")
> 8ce41bc6b147 ("x86/crash: add x86 crash hotplug support")
> 2b765af0c14f ("crash: memory and CPU hotplug sysfs attributes")
> 36d2b573329b ("kexec: exclude elfcorehdr from the segment digest")
> ccfe0040500f ("crash: add generic infrastructure for crash hotplug support")
> 626775922a57 ("crash: move a few code bits to setup support of crash hotplug")
>
next prev parent reply other threads:[~2023-08-08 18:53 UTC|newest]
Thread overview: 141+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 4:40 linux-next: build failure after merge of the mm tree Stephen Rothwell
2023-08-08 15:20 ` Eric DeVolder [this message]
2023-08-11 17:16 ` Eric DeVolder
-- strict thread matches above, loose matches on Subject: below --
2024-04-30 0:38 Stephen Rothwell
2024-04-30 2:23 ` Lance Yang
2024-04-23 0:22 Stephen Rothwell
2024-04-12 6:39 Stephen Rothwell
2024-04-11 23:14 Stephen Rothwell
2024-04-07 23:15 Stephen Rothwell
2024-04-08 1:44 ` Barry Song
2024-04-05 2:55 Stephen Rothwell
2024-03-28 4:34 Stephen Rothwell
2024-03-05 4:26 Stephen Rothwell
2024-03-05 6:39 ` Qi Zheng
2024-02-14 3:57 Stephen Rothwell
2024-02-14 15:19 ` Andrew Morton
2024-02-15 3:47 ` Stephen Rothwell
2024-02-07 6:17 Stephen Rothwell
2024-02-01 2:57 Stephen Rothwell
2024-02-01 8:35 ` Marco Elver
2024-01-25 3:29 Stephen Rothwell
2024-01-25 14:29 ` Baoquan He
2024-01-25 18:03 ` Stephen Rothwell
2024-01-24 23:23 Stephen Rothwell
2024-01-24 23:52 ` Suren Baghdasaryan
2024-01-25 2:40 ` Baoquan He
2024-01-23 23:05 Stephen Rothwell
2024-01-23 23:14 ` Suren Baghdasaryan
2023-12-21 7:38 Stephen Rothwell
2023-12-21 7:45 ` Changbin Du
2023-11-28 21:45 Stephen Rothwell
2023-11-28 22:45 ` Andrew Morton
2023-11-29 8:17 ` Dmitry Rokosov
2023-11-30 22:12 ` Stephen Rothwell
2023-11-27 3:44 Stephen Rothwell
2023-12-22 0:16 ` Stephen Rothwell
2023-12-22 6:26 ` Andrew Morton
2023-11-27 2:28 Stephen Rothwell
2023-11-27 3:48 ` Stephen Rothwell
2023-11-30 22:04 ` Stephen Rothwell
2023-11-30 22:32 ` Andrew Morton
2023-11-30 22:39 ` Michael Ellerman
2023-11-30 22:52 ` Andrew Morton
2023-12-01 3:12 ` Michael Ellerman
2023-12-07 12:38 ` Michael Ellerman
2023-10-03 22:50 Stephen Rothwell
2023-09-27 23:22 Stephen Rothwell
2023-09-28 6:47 ` Arnd Bergmann
2023-09-25 23:18 Stephen Rothwell
2023-08-22 22:52 Stephen Rothwell
2023-08-21 23:55 Stephen Rothwell
2023-08-22 1:11 ` Matthew Wilcox
2023-08-22 1:22 ` Stephen Rothwell
2023-08-22 1:34 ` Matthew Wilcox
2023-08-22 4:00 ` Darrick J. Wong
2023-08-22 20:20 ` Matthew Wilcox
2023-08-22 7:12 ` Michael Ellerman
2023-07-26 5:14 Stephen Rothwell
2023-07-26 13:22 ` Kuan-Ying Lee (李冠穎)
2023-07-26 4:53 Stephen Rothwell
2023-07-26 5:22 ` Aneesh Kumar K.V
2023-07-26 6:51 ` Stephen Rothwell
2023-07-19 4:32 Stephen Rothwell
2023-07-19 5:55 ` Alistair Popple
2023-07-18 0:02 Stephen Rothwell
2023-07-18 13:43 ` Andy Shevchenko
2023-07-18 17:34 ` Andrew Morton
2023-07-18 21:07 ` Andy Shevchenko
2023-07-17 23:40 Stephen Rothwell
2023-07-04 2:23 Stephen Rothwell
2023-07-04 2:32 ` Linus Torvalds
2023-07-04 5:51 ` Suren Baghdasaryan
2023-06-13 6:21 Stephen Rothwell
2023-06-13 15:58 ` Catalin Marinas
2023-05-19 2:43 Stephen Rothwell
2023-05-19 8:19 ` Arnd Bergmann
2023-05-17 23:59 Stephen Rothwell
2023-03-06 2:54 Stephen Rothwell
2023-03-06 3:13 ` Andrew Morton
2023-03-06 0:52 Stephen Rothwell
2023-03-06 21:58 ` Stephen Rothwell
2023-02-07 4:37 Stephen Rothwell
2023-02-07 12:17 ` Jason Gunthorpe
2023-02-08 2:41 ` Stephen Rothwell
2023-02-07 14:25 ` David Howells
2023-01-30 5:14 Stephen Rothwell
2023-01-30 8:09 ` Christian Brauner
2023-02-26 22:18 ` Stephen Rothwell
2023-02-27 10:36 ` Christian Brauner
2023-01-27 6:36 Stephen Rothwell
2023-01-27 6:16 Stephen Rothwell
2023-01-27 5:59 Stephen Rothwell
2023-01-27 13:11 ` Jan Kara
2023-01-31 21:47 ` Stephen Rothwell
2023-02-24 4:40 ` Stephen Rothwell
2023-02-24 6:01 ` Linus Torvalds
2023-02-24 20:36 ` Stephen Rothwell
2023-01-25 3:05 Stephen Rothwell
2022-12-16 1:26 Stephen Rothwell
2022-12-16 3:04 ` Andrew Morton
2022-12-16 0:21 Stephen Rothwell
2022-12-16 0:35 ` Andrew Morton
2022-12-16 1:03 ` Masami Hiramatsu
2022-11-22 6:53 Stephen Rothwell
2022-11-22 10:31 ` David Hildenbrand
2022-11-03 5:02 Stephen Rothwell
2022-11-02 3:55 Stephen Rothwell
2022-11-02 21:26 ` Andrew Morton
2022-10-18 1:24 Stephen Rothwell
2022-09-23 8:12 Stephen Rothwell
2022-09-23 8:15 ` David Hildenbrand
2022-09-23 7:55 Stephen Rothwell
2022-09-23 9:50 ` Michael Walle
2022-09-23 11:01 ` Naoya Horiguchi
2022-09-15 7:07 Stephen Rothwell
2022-09-15 16:37 ` Mike Kravetz
2022-09-15 20:06 ` Andrew Morton
2022-09-06 11:03 Stephen Rothwell
2022-09-06 12:05 ` Rob Clark
2022-09-06 18:05 ` Stephen Rothwell
2022-08-26 7:10 Stephen Rothwell
2022-08-26 7:32 ` Michal Hocko
2022-07-08 9:44 Stephen Rothwell
2022-07-08 15:17 ` Darrick J. Wong
2022-07-10 22:28 ` Stephen Rothwell
2022-05-12 9:38 Stephen Rothwell
2022-05-12 10:13 ` Baolin Wang
2022-05-12 11:07 ` Catalin Marinas
2022-05-12 11:13 ` Baolin Wang
2022-05-12 13:28 ` Catalin Marinas
2022-05-12 19:10 ` Andrew Morton
2022-05-13 7:18 ` Stephen Rothwell
2022-05-11 8:15 Stephen Rothwell
2022-05-11 8:27 ` Baolin Wang
2022-05-11 8:42 ` Baolin Wang
2022-05-11 23:28 ` Stephen Rothwell
2022-05-10 11:25 Stephen Rothwell
2022-05-05 21:37 Stephen Rothwell
2022-05-02 10:49 Stephen Rothwell
2022-05-02 11:19 ` Matthew Wilcox
2022-05-03 6:45 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c71182b-f7f1-e14b-4c65-f2c78ca58d1c@oracle.com \
--to=eric.devolder@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=sourabhjain@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).